Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update closed-functionality.md - modify examples for comments on clos… #307

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

pday1
Copy link
Contributor

@pday1 pday1 commented Jan 24, 2024

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for wcag2ict ready!

Name Link
🔨 Latest commit 8981f20
🔍 Latest deploy log https://app.netlify.com/sites/wcag2ict/deploys/65b141bd1255860008a4f29a
😎 Deploy Preview https://deploy-preview-307--wcag2ict.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maryjom
Copy link
Contributor

maryjom commented Jan 24, 2024

@pday1 I see that your goal in this PR was to simplify the list of examples. However, I think people were OK with this list having a bit more detail (explanation) than in the term definition's list. Especially the eBook example, as Shadi had asked for me to leave that as it was in the 2013 WCAG2ICT.

..after looking at the second PR you did, I see that these seem to have swapped. More detail in definition, less in the main intro. If so, I have no problem with that.

@maryjom
Copy link
Contributor

maryjom commented Jan 24, 2024

@pday1 After looking at the two PRs you did, I think I understand what was done. The more detailed examples were moved into the definition, and the basic version of the examples are in the Closed Functionality intro section - swapping their location. Am I getting that right?

closed-functionality.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that this list of examples is an improvement.

@maryjom maryjom merged commit efa76f9 into mjm-2nd-proposal-closed Feb 1, 2024
6 checks passed
@maryjom maryjom deleted the pday1-patch-2 branch February 8, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants