This repository has been archived by the owner on Jun 30, 2018. It is now read-only.
Issue 57 Line Length SC #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I left it as 25 characters line length, although some thought that was too short a line to require (45-65 characters suggested). I also added “Blocks of text” as a compromise with James Nurthan’s concern. See #57
|
David, I don't think that worked. I'm not sure what went wrong but it is showing the guidelines index as initially empty and then your changes bring in all of the content. Odd. Also, you should be making the pull request on the FPWD branch. |
|
I see what I did wrong... I cloned it to my local Github desktop from here rather than forking it to my Github repro and cloning it from there. |
|
You can delete it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left it as 25 characters line length, although some thought that was
too short a line to require (45-65 characters suggested). I also added
“Blocks of text” as a compromise with James Nurthan’s concern. See
#57.
This is a test.