Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running builds against a custom local guidelines folder #4182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Dec 20, 2024

These changes are part 1 of 2 to enable preview builds against the WCAG-2.1 branch. This part applies to the main branch; see #4183 for part 2, which applies to WCAG-2.1.

This adds logic to getPrinciples and getTermsMap code flows to allow explicitly specifying a local guidelines/index.html path when building for a specific version, to be used in place of requesting the latest published recommendation for the specified WCAG_VERSION. This allows us to directly reuse the build process from the main branch for generating preview builds against WCAG-2.1, rather than needing to copy the entire Eleventy build process to that branch and keep it in sync.

I have verified that this does not cause any changes to existing builds without the new variable, with WCAG_VERSION set to 22, 21, or unset.

@kfranqueiro kfranqueiro requested a review from iadawn December 20, 2024 22:52
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit fe942fa
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6765f517a1617a0008f3aaec
😎 Deploy Preview https://deploy-preview-4182--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant