Pin guidelines/* content when publishing 2.2 docs to w3.org #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
kfranqueiro
force-pushed
the
kgf-pin-22-guidelines
branch
from
b7f246b to
e448e70
Compare
iadawn
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same publication-version-pinning logic added in #4007 for 2.1 docs, to 2.2 docs specifically when built for w3.org, so that guideline/SC and definition text included within informative docs matches the published recommendation. Local dev and gh-pages builds continue to run against
guidelinesin the local repository (effectively the Editor's Draft).The build uses the published recommendation whenever
WCAG_VERSIONis specified, so enabling this for w3.org builds only requires adding that environment variable explicitly to thepublish-w3cscript.The changes to
11ty/guidelines.tsfix cases that were never exhibited in the 2.1 build, but came up when testing building 2.2 against the published recommendation.