-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech flexbox reflow #388
Tech flexbox reflow #388
Conversation
Same issues for grid reflow would apply to flexbox reflow regarding clarity of testing the horizontal and vertical aspects separately and how the requirements only apply to content scrolling in that direction and the need to set a starting viewport width before zooming 400%. |
- vertical / horizontal text separated - Link to CSS spec added - Code example updated - Test procedure vertical / horizontal text separated
Hi @mraccess77, @alastc, I've made some updates based on #387, you can see them in this diff. @alastc , how can we show a live example when pull request is not processed? |
changes: vertical / horizontal separation
|
I think this is a perfect candidate for a failure technique:
|
+1, with a minor editorial change: For step 4 of both test procedures, a slight editorial change from "whether" to "that". Rationale is that the test processes lead to a result, that is then tested to be true.
becomes
(with same wording change in the second procedure covering vertical) |
Hi @mbgower, thx for the inspect and suggestions, after my vacation will do the changes and techniques. Cheers! |
+1 |
+1 |
+1
…On Tue, Aug 21, 2018 at 12:56 PM Laura Carlson ***@***.***> wrote:
+1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#388 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG_WL2XV6GCOv-ktVuqDSmwcbLCywx_Wks5uTEm9gaJpZM4U7LOb>
.
--
Jim Allan, Accessibility Coordinator
Texas School for the Blind and Visually Impaired
1100 W. 45th St., Austin, Texas 78756
voice 512.206.9315 fax: 512.206.9452 http://www.tsbvi.edu/
"We shape our tools and thereafter our tools shape us." McLuhan, 1964
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@mbgower, the last part (4.) of the procedure suggests no scrolling is allowed at all, so we'll need to be clear on the separation. If we are not going to split the two up at least I think we should separate them in another sentence. After some re-reading the previous / first suggestion would be fine after all with the only adjustment to replace "whether" to "that" resulting in: Same suggestion for #387 Any objections? Procedure
NB: If the browser is not capable of zooming to 400%, you can reduce the width of the browser proportionally. For example, at 300% zoom the viewport should be sized to 960px wide. Expected Results |
Replaced the separation
|
Removed the applicability content (assiming it defaults to CSS). Removed the section on complex layouts. Added resource links. Converted note to class=note. Added test procedure from the grids example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok from a source code readiness perspective. I'm a little unsure about the "NB", I'm inclined to say it should be just a note (with class="note"), but if it's a different semantic we think we'll introduce, perhaps we should create a class and generator support for it? As is it sticks out to me, but not enough to not approve the technique for the moment.
Ach, that wasn't intentional, I have a severe muscle-memory for "NB" I'm trying to train myself out of! Converted it. |
Saying what to do in the exmple.
NB: I moved the example into this branch in preparation for publication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to standardize working-example link and expected results, and link to related technique also in the queue
New technique for reflow, you can preview Flexbox reflow, and there is an associated example page.