Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates test steps in F94 #3739

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Updates test steps in F94 #3739

merged 9 commits into from
Jul 10, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Mar 10, 2024

  • Removes 1280 pixels wide step
  • Removes the unnecessary preamble before the test steps, and tweaks the last line of the test procedure to reference the last step, rather than giving it a number
  • Additionally, cleans up formatting of the HTML

Closes #704

@alastc
Copy link
Contributor

alastc commented Mar 15, 2024

I was thinking that it should start the procedure with

For each page variation (such as break points in media queries) use any of the following methods to resize text when available:

But, given the context of a failure technique about view-port units, is that needed?

@patrickhlauke
Copy link
Member Author

given the context of a failure technique about view-port units, is that needed?

only IF there is a hint about the site that fails using breakpoints with different styles for font sizing, and only one particular breakpoint switching to viewport units. which there isn't in the way the technique is written, so long way of saying ... no?

@patrickhlauke
Copy link
Member Author

As discussed last week, filed a follow-up #3876

@mbgower
Copy link
Contributor

mbgower commented Jun 7, 2024

@patrickhlauke the follow-up doesn't meaningfully change this PR, right? Is there any reason we wouldn't just incorporate here?

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Jun 7, 2024

Is there any reason we wouldn't just incorporate here?

at the meeting two/three weeks ago @alastc said we shouldn't spend any more time on this PR, and if i felt strongly about more changes that bubbled up in our discussion (the follow-up part) it should be filed separately...

@mbgower mbgower changed the title Remove "1280 pixels wide" test step from F94 Updates test steps in F94 Jun 24, 2024
Copy link
Contributor

@detlevhfischer detlevhfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

techniques/failures/F94.html Show resolved Hide resolved
@mbgower mbgower merged commit e293dc7 into main Jul 10, 2024
1 check passed
@mbgower mbgower deleted the patrickhlauke-f94-test-steps branch July 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure technique F94 (1.4.4 resize text): remove "1280 pixels wide" step in test procedure
6 participants