Update ARIA12 #3734
Merged
Update ARIA12 #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify that `aria-level` must be used. - Update examples to use `aria-level`. - Remove link to APG as the referenced content isn’t there anymore. - Update test procedure for `aria-level`. - Add note about `aria-level` values of 10 and greater. - Add link to `aria-level` spec. - Add link to HTML headings spec.
PhilippeVay
reviewed
Apr 2, 2024
fixing a very old typo
patrickhlauke
approved these changes
Apr 5, 2024
mbgower
reviewed
Apr 12, 2024
techniques/aria/ARIA12.html
Outdated
| </li> | ||
| </ol> | ||
| <aside class="note"> | ||
| <p>Headings with an <code class="language-html">aria-level</code> of 10 or higher can create difficulties for users. At the time of writing, most combinations of user agents and assistive technologies report such levels as being level 2.</p> |
There was a problem hiding this comment.
That seems really odd to me. Is there a reference?
There was a problem hiding this comment.
I mentioned it in the issue—I found it in the ARIA 1.3 draft and tweaked it a bit.
There was a problem hiding this comment.
Also discussed in this week's backlog meeting, here's a reference CodePen so you can test this yourself should you wish :)
alastc
reviewed
Apr 12, 2024
Co-authored-by: Alastair Campbell <[email protected]>
|
Discussed on TF call 4/12 and Ready for approval |
scottaohara
reviewed
Apr 15, 2024
I'm good with this. Co-authored-by: Scott O'Hara <[email protected]>
|
Note the additional change that was merged into this 4c06779 |
scottaohara
approved these changes
Apr 19, 2024
iadawn
added a commit
that referenced
this pull request
May 2, 2024
* Headings need to be in ```<section>```s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3733
aria-levelmust be used.aria-level.aria-level.aria-levelvalues of 10 and greater.aria-levelspec.