-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update .html files for xslt/xml processing #3572
Conversation
* change `<link …></link>` to self-closing `<link … />` ... not elegant, but at least not invalid html * add `xml:space="preserve"` to all instances of `<pre>` to maintain spaces through xslt transformation
Someone who can build the docs locally needs to test this (me and Francis so far). |
@iadawn this seems to build ok for me, can you have a look to see if there are any issues for the guidelines index or other respec docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will confess to being slightly perplexed by this one. However, I have built stuff and checked ReSpec and there are no issues that I can spot.
So this update looks ok (with approval from Kevin), but we've got a bunch of conflicts now, could you try and resolve those @patrickhlauke? |
done |
@patrickhlauke could you walk the TF through this on the call next Friday, 8 March? As has been the pattern, probably alastair or Michael will be screen sharing. |
sure |
Hmm, I just tried to build and got... I think essentially there's a clash between the build-process expecting valid XHTML, and your editing environment expecting valid HTML... but in the current state that will block all new updates to the documents if it is merged. So either that change needs to be undone, or perhaps there's a way of getting the XSL to accept the @patrickhlauke it would be good to get a local build setup, it should only take about 5 minutes, then you'll be able to work out if a change breaks things. (I'm not sure why this didn't happen before, it looks like someone did manage to build it above?) |
that was an oversight, i forgot to add the self-closing slash to that particular file's
XSL is fine with self-closing elements, as it's valid XML. the error you got was in that one file because I forgot it (but will check that i didn't slip up in other files as well)
anything that starts with "install java" gets a hard pass from me ;) |
@alastc try now |
Briefly discussed on call 3/22/2024. |
<link …></link>
to self-closing<link … />
... not elegant, but at least not invalid htmlxml:space="preserve"
to all instances of<pre>
to maintain spaces through xslt transformationPreview | Diff