Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update .html files for xslt/xml processing #3572

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Nov 29, 2023

  • change <link …></link> to self-closing <link … /> ... not elegant, but at least not invalid html
  • add xml:space="preserve" to all instances of <pre> to maintain spaces through xslt transformation

Preview | Diff

* change `<link …></link>` to self-closing `<link … />` ... not elegant, but at least not invalid html
* add `xml:space="preserve"` to all instances of `<pre>` to maintain spaces through xslt transformation
@alastc
Copy link
Contributor

alastc commented Dec 1, 2023

Someone who can build the docs locally needs to test this (me and Francis so far).

@alastc
Copy link
Contributor

alastc commented Dec 4, 2023

@iadawn this seems to build ok for me, can you have a look to see if there are any issues for the guidelines index or other respec docs?

@alastc alastc assigned iadawn and unassigned alastc Dec 4, 2023
Copy link
Contributor

@iadawn iadawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will confess to being slightly perplexed by this one. However, I have built stuff and checked ReSpec and there are no issues that I can spot.

@alastc
Copy link
Contributor

alastc commented Feb 28, 2024

So this update looks ok (with approval from Kevin), but we've got a bunch of conflicts now, could you try and resolve those @patrickhlauke?

@alastc alastc assigned patrickhlauke and unassigned iadawn Feb 28, 2024
@patrickhlauke
Copy link
Member Author

we've got a bunch of conflicts now, could you try and resolve those @patrickhlauke?

done

@bruce-usab
Copy link
Contributor

bruce-usab commented Feb 29, 2024

@patrickhlauke could you walk the TF through this on the call next Friday, 8 March? As has been the pattern, probably alastair or Michael will be screen sharing.

@patrickhlauke
Copy link
Member Author

sure

@alastc
Copy link
Contributor

alastc commented Mar 8, 2024

Hmm, I just tried to build and got...
BUILD FAILED /Sites/wcag/build.xml:167: ; SystemID: file:/Sites/wcag/xslt/generate-technique-associations.xslt; Line#: 24; Column#: 32 net.sf.saxon.trans.XPathException: org.xml.sax.SAXParseException; systemId: file:/Sites/wcag/understanding/22/accessible-authentication-enhanced.html; lineNumber: 7; columnNumber: 3; The element type "link" must be terminated by the matching end-tag "</link>".

I think essentially there's a clash between the build-process expecting valid XHTML, and your editing environment expecting valid HTML... but in the current state that will block all new updates to the documents if it is merged.

So either that change needs to be undone, or perhaps there's a way of getting the XSL to accept the <link />?

@patrickhlauke it would be good to get a local build setup, it should only take about 5 minutes, then you'll be able to work out if a change breaks things. (I'm not sure why this didn't happen before, it looks like someone did manage to build it above?)

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Mar 8, 2024

@alastc

I just tried to build and got

that was an oversight, i forgot to add the self-closing slash to that particular file's <link>. I'll have a check to make sure all others are kosher.

getting the XSL to accept the <link />

XSL is fine with self-closing elements, as it's valid XML. the error you got was in that one file because I forgot it (but will check that i didn't slip up in other files as well)

would be good to get a local build setup,

anything that starts with "install java" gets a hard pass from me ;)

@patrickhlauke
Copy link
Member Author

@alastc try now

@bruce-usab
Copy link
Contributor

Briefly discussed on call 3/22/2024.

@mbgower mbgower merged commit 68a3875 into main Apr 2, 2024
1 check passed
@mbgower mbgower deleted the patrickhlauke-html-file-cleanup branch April 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants