Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added info on inactive components to contrast Understandings #3176

Closed
wants to merge 24 commits into from
Closed

Added info on inactive components to contrast Understandings #3176

wants to merge 24 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented May 5, 2023

Resolves #481

patrickhlauke and others added 24 commits February 12, 2023 16:23
@patrickhlauke
Remove pointlessly duplicated content
1cabaf8
@patrickhlauke
Replace "fancy" with "unusual", qualify where the note is
c9b5670
@patrickhlauke
Use <code>
1edaed5
@patrickhlauke
Reorder content of Rationale to match the enhanced understanding
3f69582
@patrickhlauke
Replace incorrect plural "Success Criteria" in note with simpler and …
864acb5 
…less repetitive "here"
@patrickhlauke
Consisteny captialisation of "Success Criterion"
5477292
@patrickhlauke
Use lowercase and no space ppi rather than PPI and use <code>
9089e54
@patrickhlauke
Correct and tweak cross-reference to 1.4.5 Images of Text
2c8794e
@patrickhlauke
Use correct link format for SC cross-referencing
906c082
@patrickhlauke
Missed out a <code>, reformatting whitespace/line lengths
75a4414
@patrickhlauke
Add new note about thin/unusual fonts that nominally pass but in prac…
d1ef550 
…tice fail
@patrickhlauke
Some more <code> uses
2fd9647
@patrickhlauke
Remove incorrect (?) / confusing statement about not specifying text …
663fd42 
…color
@patrickhlauke
Port all changes to 1.4.6 Contrast (Enhanced) understanding as well
c2cbfdf
@patrickhlauke
Tweak thin/unusual font note (remove the "we recommend", emphasise th…
7a954d2 
…is is best practice only)
@mbgower
Update contrast-enhanced.html
6653aac 
added standard comma after e.g.
@mbgower
Update contrast-enhanced.html
6fdf292 
added commas for minor editorial changes for readability
@mbgower
Update contrast-minimum.html
a605651 
same trivial punctuation changes as in other file
@patrickhlauke
Expand antialiasing note to clarify how to evaluate
03427af
@patrickhlauke
Merge branch 'patrickhlauke-understanding-text-contrast' of https://g…
d33c024 
…ithub.com/w3c/wcag into patrickhlauke-understanding-text-contrast
@patrickhlauke
Typo
2fad324
@patrickhlauke
Tweak cognitive note wording
31316b3
@mbgower
Added info on inactive components to contrast Understandings
e121952 
As per
@mbgower
removed second paragraph
b00b439 
As per 2.x backlog call
@mbgower mbgower changed the base branch from patrickhlauke-understanding-text-contrast to main May 5, 2023 15:43
@mbgower mbgower marked this pull request as ready for review May 5, 2023 15:43
@mbgower mbgower closed this May 5, 2023
@mbgower
Copy link
Contributor Author

mbgower commented May 5, 2023

I had to redo as #3177 because since I branched off Patrick's changes to #3020 , those were all included.
To keep the changes cleaner, I rebranched from main

@kfranqueiro kfranqueiro deleted the mikegower-inactive-controls-info2 branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.4.3 Contrast (min) 1.4.6 Contrast (enh) 1.4.11 Non-text contrast Topic WCAG 2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include details on user interface components in 1.4.3 & 1.4.6 Understanding
3 participants
@mbgower @alastc @patrickhlauke