Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating example in On Input Understanding within note #2984

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

awkawk
Copy link
Member

@awkawk awkawk commented Jan 31, 2023

Updating in response to discussion on #2982

Updating in response to discussion on #2982
@fstrr fstrr closed this May 29, 2024
@fstrr fstrr deleted the awkawk-patch-1 branch May 29, 2024 02:51
@patrickhlauke
Copy link
Member

This seemed good to me, to be honest. I'd reopen it

@patrickhlauke patrickhlauke restored the awkawk-patch-1 branch June 7, 2024 10:18
@patrickhlauke patrickhlauke reopened this Jun 7, 2024
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By substituting BUTTON for TAB, edit adds a little clarity.

In OP issue #2982 noted that TAB having "selected" as possible programmatic status makes TAB a less-than-ideal example.

@patrickhlauke patrickhlauke self-assigned this Jun 21, 2024
@mbgower mbgower changed the title Updating example within note Updating example in On Input Understanding within note Jun 28, 2024
@mbgower
Copy link
Contributor

mbgower commented Jul 29, 2024

Reviewed on Monday. Looks fine. Merging.

@mbgower mbgower merged commit 9ce41e5 into main Jul 29, 2024
1 check failed
@mbgower mbgower deleted the awkawk-patch-1 branch July 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants