-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to 2.1.4 Character Key Shortcuts understanding #2455
Add note to 2.1.4 Character Key Shortcuts understanding #2455
Conversation
Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed. Also correct a typo, and gives the document a proper `<title>` (though irrelevant, as this is changed on publication, it's still nice for good housekeeping). Closes #2314
…uts/keys mentioned in the document
ba89b40
to
b4d5531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@alastc any chance this could be discussed/considered at some point soon? |
correct indentation of the html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the revised understanding have something on videos processing single printable key shortcuts once they receive focus? The question has been popping up (can't remember where) whether the whole of the video as it receives focus can count as "user interface component" to allow it to be "active only on focus". I can see a good case for allowing that, and I'am not aware of drawbacks. Not sure whether this question should be lumped together with this clarifying rewrite though...
@detlevhfischer i'd keep that thing about video players separate, as a resolution to #1950 (if we ever manage to get some consensus, and then if we ever manage to actually make a PR and merge something in a timely fashion ;) ) |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me!
Co-authored-by: Alastair Campbell <[email protected]>
When #3939 was merged, conflicts were not resolved correctly, resulting in loss of #2455's update to 2.1.4 and loss of #3939's original update to 2.3.3. This PR cleanly re-applies my original changes from #3939, restoring those other lost updates. --------- Co-authored-by: Patrick H. Lauke <[email protected]>
Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed.
Also corrects a typo, gives the document a proper
<title>
(though irrelevant, as this is changed on publication, it's still nice for good housekeeping), and uses<kbd>
for the characters mentioned.Closes #2314