Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to 2.1.4 Character Key Shortcuts understanding #2455

Merged
merged 13 commits into from
Aug 27, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented May 22, 2022

Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed.
Also corrects a typo, gives the document a proper <title> (though irrelevant, as this is changed on publication, it's still nice for good housekeeping), and uses <kbd> for the characters mentioned.

Closes #2314

Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed.
Also correct a typo, and gives the document a proper `<title>` (though irrelevant, as this is changed on publication, it's still nice for good housekeeping).

Closes #2314
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue2314-character-key-understanding branch from ba89b40 to b4d5531 Compare May 22, 2022 20:49
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patrickhlauke
Copy link
Member Author

@alastc any chance this could be discussed/considered at some point soon?

Copy link
Contributor

@detlevhfischer detlevhfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the revised understanding have something on videos processing single printable key shortcuts once they receive focus? The question has been popping up (can't remember where) whether the whole of the video as it receives focus can count as "user interface component" to allow it to be "active only on focus". I can see a good case for allowing that, and I'am not aware of drawbacks. Not sure whether this question should be lumped together with this clarifying rewrite though...

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Feb 7, 2023

@detlevhfischer i'd keep that thing about video players separate, as a resolution to #1950 (if we ever manage to get some consensus, and then if we ever manage to actually make a PR and merge something in a timely fashion ;) )

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit ff59653
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/66c4ec975709de000831d429
😎 Deploy Preview https://deploy-preview-2455--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patrickhlauke patrickhlauke marked this pull request as draft July 31, 2024 08:42
@patrickhlauke patrickhlauke marked this pull request as ready for review July 31, 2024 09:18
@mbgower mbgower self-assigned this Aug 2, 2024
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me!

@mbgower mbgower merged commit 57725c9 into main Aug 27, 2024
5 checks passed
@mbgower mbgower deleted the patrickhlauke-issue2314-character-key-understanding branch August 27, 2024 16:13
kfranqueiro added a commit that referenced this pull request Aug 30, 2024
When #3939 was merged, conflicts were not resolved correctly, resulting
in loss of #2455's update to 2.1.4 and loss of #3939's original update
to 2.3.3.

This PR cleanly re-applies my original changes from #3939, restoring
those other lost updates.

---------

Co-authored-by: Patrick H. Lauke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Understanding for 2.1.4 Character Key Shortcuts may require some disambiguation
6 participants