-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite for 3.3.1 Error Identification understanding document #1651
Conversation
* remove the misleading statement about screen reader users needing to know that an error occurred before hitting one of the indicators/fields. this implicitly suggests that the intent is for an error message/list to be shown to (screen reader) users before the actual form, which is not in fact the intention nor the requirement of this SC * tweak the benefit for users with cognitive/language/learinng disabilities * refocus on the benefit to ALL users, not just screen reader users * add allowance for situations where an error indication is already self-explanatory/obvious from context (e.g. a form where fields have already explicitly been identified as mandatory/required - not necessary for compliance to now ALSO explicitly say "as we already told you, this field is mandatory")
5ac946a
to
1d8a008
Compare
- "Per the definition in WCAG 2.0" is unnecessary and outdated now anyway - added note to clarify that the SC does not mandate any specific way in which errors are shown (as a list, alert, dialog, or inline), but only that the error must be in text if not already obvious
…ive wording (describe to...)
I like the updates! I agree for a login form that additional error for an empty field is not required as in a simple form it is assumed these two fields are required. |
For the last bullet where a field is already marked required - if the field is using an asterisk and the asterisk is described at the top of the form as indicated a required field are we now saying nothing else needs to be said/done - so when the user submits the form with a missing required field the focus could just stay on submit and no visual changes need to take place? I just want to make sure we have thought of all situations. |
For the last bullet it's saying that error still needs to be indicated, but a redundant additional explanation in text may not be needed.
i.e. no need to have a field that was marked as required, after failing has now an additional indication (like a warning triangle)...i'd argue there's no point now also requiring a repetitious and not very informative "You must fill in this required field" just to satisfy the "error is described in text". |
FWIW, I have always understood that |
I believe it's reasonable that login forms should not have to have required field indicators as by nature of authentication you have to enter a username and password. However, upon submitting without entering one or the other or invalid content then I'd expect some sort of error message to then be required. |
but for those situations where it's quite clear from context (e.g. of course you can't log in with only a username and not providing a password), does the error absolutely need to be conveyed in text, or is it then sufficient to provide an error indication (which could be just an icon or similar - provided it passes other SCs like 1.1.1, 1.4.11, etc) without the need for words? that's the circle i was trying to square here with some nuance/human judgement. |
I personally think an icon that indicates missing field with alt text is sufficient when combined with the implicit or explicit required state. |
Per Gundula's comment
Per mbgower's comment
I see this has a |
Co-authored-by: Wilco Fiers <[email protected]>
@gundulaniemann @patrickhlauke I think your discussion about whether the understanding doc should include an example of whether a login form needs to clarify whether username vs password was incorrect is a good discussion and something that it'd be helpful to add an example for, but probably out of scope for this PR. I think existing issue #2175 covers this already (the title says 3.3.3 but the discussion/labels clarify that it's scoped to both 3.3.3 and 3.3.1) |
it is not sufficient to only re-display the form without providing any hint that the submission | ||
failed. | ||
The error can be indicated in <a>text</a>, which does allow for visually apparent images or | ||
icons with suitable alternative text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I agree with this. 3.3.1 Error Identification specifically requires that "the error is described to the user in text." An image or an icon is not text.
IMO the error must be described in text to pass the SC. I recommend deleting the sentence formed at lines 28 and 29
In regard to the prior discussion on what is sufficient with a simple username/password field, IMO a symbol on a field would not be sufficient. It would need at a minimum something saying "Supply a username" or "The field requires a value" or "Missing value", etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll admit that, since it's been over 3 years since i wrote most of this...i can't quite recall where that phrasing i suggested came from. i'm fairly sure it bubbled up from related discussions mentioned here. (that's the joy of revisiting really old PRs)
not particularly wedded to any of these wordings at the moment, just trying to address some of the other more dramatic issues listed in the description bullets here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickhlauke I have made a suggested change which makes the need for text explicit. I'd like to revert to this, then open up a separate issue to directly address whether there is support to allow only a symbol with alt in specific circumstances.
If that works for this PR, please incorporate. Also, I struck through a bullet in the initial PR comment which lists this. Feel free to remove if you agree.
Co-authored-by: Mike Gower <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
accepted the changes that removed the suggestion that images with appropriate |
I have added this as a consideration for WCAG 3 https://github.com/w3c/wcag/wiki/WCAG-3-parking-lot-considerations-from-2.x |
One was addressed; the other was not part of the changes in this PR.
* remove the misleading statement about screen reader users needing to know that an error occurred before hitting one of the indicators/fields. this implicitly suggests that the intent is for an error message/list to be shown to (screen reader) users before the actual form, which is not in fact the intention nor the requirement of this SC * tweak the benefit for users with cognitive/language/learning disabilities * refocus on the benefit to ALL users, not just screen reader users * ~add allowance for situations where an error indication is already self-explanatory/obvious from context (e.g. a form where fields have already explicitly been identified as mandatory/required - not necessary for compliance to now ALSO explicitly say "as we already told you, this field is mandatory")~ [potentially removed by mbgower suggestion] Closes #977 --------- Co-authored-by: Alastair Campbell <[email protected]> Co-authored-by: Mike Gower <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Mike Gower <[email protected]>
add allowance for situations where an error indication is already self-explanatory/obvious from context (e.g. a form where fields have already explicitly been identified as mandatory/required - not necessary for compliance to now ALSO explicitly say "as we already told you, this field is mandatory")[potentially removed by mbgower suggestion]Closes #977