Benefits sometimes nested under Intent in source files (including template) #3924
Assignees
Comments
mbgower
added a commit
that referenced
this issue
Aug 27, 2024
#3939) Fixes #3924. Also addresses the Label in Name instance in #3922. The diff will be much easier to compare with whitespace ignored (`?w=1`). This amends all instances of the Benefits section in Understanding pages to be a top-level section with a level-2 heading. I've tested this with both the XSLT and Eleventy build processes to confirm this doesn't actually change any content, since both build processes already ensure Benefits is a top-level section with level-2 heading. The one exception is the removal of the redundant first Benefits section in Understanding 2.5.3 Label in Name, which only meaningfully affects the XSLT process, as the Eleventy process already worked around that issue. Note: I don't know what `identify-changes.html` is supposed to be, but I updated it regardless; it seems to only contain template boilerplate and is not linked from anywhere. Co-authored-by: Mike Gower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
The Benefits section in Understanding documents is always displayed as a level-2 heading and included in the table of contents, after Intent.
However, a handful of files - including
understanding-template.html- instead nest Benefits within Intent, which the build process corrects, pulling it back out to a top-level section withh2.I'm not sure if there's history behind this discrepancy, but it seems like we ought to make the source files consistent - and at the very least, make the template reflect reality.
A search for
<h3>Benefitsshould find the source files in question (as opposed to<h2>Benefitsfor ones that fit the current build behavior).The text was updated successfully, but these errors were encountered: