Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loophole in 2.5.8 Target Size (Minimum)? #3045

Closed
patrickhlauke opened this issue Feb 20, 2023 · 5 comments · Fixed by #3103
Closed

Loophole in 2.5.8 Target Size (Minimum)? #3045

patrickhlauke opened this issue Feb 20, 2023 · 5 comments · Fixed by #3103

Comments

@patrickhlauke
Copy link
Member

patrickhlauke commented Feb 20, 2023

The spacing exception has been designed with tightly packed controls in mind, but as soon as controls are far enough apart, (or, in extreme cases, there are no other controls around), it effectively loses any normative power to define a minimum size.

Taking the extreme opposite case: imagine a page that only has a single button, and no other actionable/clickable controls. Per the normative wording, using the spacing exception, it would appear that it's "legal" for that single button to be sized at 1 CSS px by 1 CSS px.

Just wondering if we want to acknowledge this loophole, or hope that nobody twigs? EDIT: acknowledge as in "at least mention it in the understanding, but also emphasise that while it may normatively pass, as a best practice authors really shouldn't do it"

@alastc
Copy link
Contributor

alastc commented Feb 22, 2023

Per the normative wording, using the spacing exception, it would appear that it's "legal" for that single button to be sized at 1 CSS px by 1 CSS px.

Agree. The alternative would be to specify some smaller minimum value, which which case that becomes the new minimum size people think about.

I'm fairly torn on adding something about it. If we do that becomes the talking point, if we don't it becomes something that some people know about and others haven't thought about.

If we did, we would need to be heavily caveated, as it's bad for everyone.

@patrickhlauke
Copy link
Member Author

as previously mentioned in a similar related conversation, i'd rather the understanding doc was very upfront about the limitations of the SC, rather than trying to hide things and hope that devs won't notice. if the explanation for the SC explicitly turned it around to "the aim is to avoid having adjacent controls that are too difficult to hit, rather than setting an absolute minimum for all targets", it then at least excuses/explains the gap here. and then we strongly suggest that as best practice, authors should also make sure their non-grouped, non-adjacent targets still have a sufficiently large size to be comfortable and easy to use.

does that weaked the SC? possibly, in the eyes of those that misunderstood it/didn't realise the consequences. but at least it's realistic (and we won't end up with some clever clogs later on after publication coming at this from a "how silly are AGWG? have they not realised this is the case? how pointless is their work?"

@dav-idc
Copy link
Contributor

dav-idc commented Mar 18, 2023

Hey there! Thought I'd try and find a relevant open issue to add in a thought I've been processing for a few weeks, but I'm not sure if this is the appropriate place to put it.

Target size (minimum) is actually about target spacing.

The listed exception of 'spacing' for 'Target Size (Minimum)' kind of makes it so that the success criterion isn't really reliant on target size at all. It's really more about having 24px of spacing between targets.

I've anecdotally found man people confused as to how the exceptions interplay with the size aspect of this criterion, and it makes me wonder if it would be clearer to frame it form the perspective of spacing instead.

Something like '2.5.8 Target Spacing', with the main description being about having that 24px by 24px spacing between targets, with an exception for targets greater than 24px by 24px.

Might help a lot with misinterpretation, as the currently drafted 'Target Size (Minimum)' is wildly different from its 'Target Size (Enhanced)' counterpart, which focuses a lot more explicitly on the actual size of a target, without a spacing exception that breaks the 44px size requirement.

Once again if this isn't the right place for the discussion, I can move this to a separate issue 👍

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Apr 23, 2023

added a commit (e21377c) on #3103 to address this

patrickhlauke added a commit that referenced this issue Apr 23, 2023
patrickhlauke added a commit that referenced this issue Apr 23, 2023
@GreggVan
Copy link

GreggVan commented Apr 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants