Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata for 2.5.5 Target Size (Enhanced) to align with 2.5.8 #2857

Open
alastc opened this issue Dec 19, 2022 · 6 comments · May be fixed by #2858
Open

Errata for 2.5.5 Target Size (Enhanced) to align with 2.5.8 #2857

alastc opened this issue Dec 19, 2022 · 6 comments · May be fixed by #2858
Labels
2.5.5 Target size (Enhanced) ErratumRaised Potential erratum for a Recommendation WCAG 2.1

Comments

@alastc
Copy link
Contributor

alastc commented Dec 19, 2022

There is a proposed update in #2856 for Target Size (min) to the "inline" exception:
"The target is in a sentence, or the size of the target is otherwise constrained by the line-height of non-target text;"

I think this is a clearer and more testable version, and would like to update SC 2.5.5 in WCAG 2.1 on that basis.

@alastc alastc added ErratumRaised Potential erratum for a Recommendation WCAG 2.1 2.5.5 Target size (Enhanced) labels Dec 19, 2022
@alastc alastc linked a pull request Dec 19, 2022 that will close this issue
@GreggVan
Copy link

GreggVan commented Dec 19, 2022 via email

@alastc
Copy link
Contributor Author

alastc commented Dec 19, 2022

Hi Gregg,

In the discussion on Friday people generally found "line height" easier to understand than "inter-line spacing".

We didn't discuss line-spacing, but (putting the exact typographical definitions to one side), the size of a link in a line of text wouldn't be constrained by the spacing around the line. It would be constrained by the size of the line it is within.

In the PR (#2858) for the AA version there is a note underneath:
"For inline targets the line-height should be interpreted as perpendicular to the flow of text. For example, in a language displayed top to bottom, the line-height would be horizontal."

Does that work for you?

@GreggVan
Copy link

GreggVan commented Dec 19, 2022 via email

@GreggVan
Copy link

GreggVan commented Dec 20, 2022 via email

@patrickhlauke
Copy link
Member

xref #3086

@fstrr
Copy link
Contributor

fstrr commented May 28, 2024

Is this issue still being worked on? There's a related branch from December 2022 that is up for deletion unless it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.5.5 Target size (Enhanced) ErratumRaised Potential erratum for a Recommendation WCAG 2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants