-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Understanding Success Criterion 1.4.11: Non-text Contrast - Figure 15 #2494
Comments
Hi! I was just going to ask that question. I agree, this looks like it would pass use of color. Maybe the intention was to keep the text white? If the text was kept white, then the background change would be a use of color because its the only thing that changes. |
the current image to illustrate how a simple change of background colour is not in scope of 1.4.11 non-text contrast actually muddies things, because the focused button also has a different text colour and a white halo/shadow around the text. this example *only* changes the background colour - and, to keep it more consistent with the other examples, it uses the light blue for the non-focused buttons and the dark blue for the focused one. Closes #2494
made a replacement image that should be clearer #2574 |
Thank you @patrickhlauke, it's perfect now. I do still have some concerns, but maybe would be better to open a separate issue for it: |
fair point, was actually looking at that while hacking together that newer image. it might indeed be worth making sure the examples for 1.4.11 don't actually fail 1.4.3. I'll see if I can replicate all the "Example" button images with a more contrasty substitute... (actually tempted to see if it makes more sense to go down the SVG route for these example images, for more flexibility later on in editing them) |
@giacomo-petri expanded the PR #2574 to also at least make the text in those buttons obviously (and consistently) "large text" (they're now 21px and bold) |
fails Use of Color. also, please don't use issues (that discuss clarifications/changes to the spec and related documentation) to just ask questions / get opinions like this... |
Thank you. Adding such scenario to page might help. |
As per 1.4.1
Keeping text to be white, we will have a contrast ratio issue, but at least it will fail the Use of color criterion and will be consistent with description below.
Giacomo
The text was updated successfully, but these errors were encountered: