-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus appearance rewording of bullet 2 for Focus Visible (Enhanced) #1212
Comments
Hi ajanec01,
In combination with the first bullet, the indicator which meets bullet 2 (change of contrast), must also meet bullet 1 (size). If the thick underline meets the size requirement (3px thick would do it), then it meets the size requirement. It is a similar concept to the example of gradients. We don't want to punish extra indication, just make sure there is a minimum. If we took your proposed text, then I think it would require the yellow background to meet contrast, which is not the intent. |
Hi @alastc Thanks for the clarification! Yes, I think that the understanding section and mainly the example of gradients convey the intent. I'm just not so sure about the wording of the focus contrast point. I see some sort of disconnect between bullet point number two and the other points. The creation of the minimum area bullet point and the last note indicate two focus indication areas: minimum focus indication area and parts which are not within the minimum area. As such, the way I read it at the moment is:
I actually thought that by adding the phrase "required to identify focus" would exclude the parts of focus indication that are not required for conformance, i.e. the background colour change or anything above the minimum area. I also thought that it would be consistent with sc 1.4.11 where the "required to identify" is also used and it is limiting the scope of what needs to be tested. |
FYI, the text has changed since the first draft, latest is in this understanding doc.
I'll have a think, it would need to be a careful change. |
Perhaps the most straightforward change would be: "Change of contrast: The color change for the focus indication area has a contrast ratio of at least 3:1 with the colors of the unfocused state." |
That sounds good to me! There would be a clear connection between the first three bullet points. Also, the first paragraph is more specific than the one in the first draft. Thanks for the link to the latest version! I was referencing the old one as that's the one being used on the understanding focus visible page. |
That link is for the old 2.4.7, which doesn't have any of the language, I think you were referencing the 1st draft. Anyway, we should have the new text up in the next 2-3 weeks. |
Yes I was, sorry for the confusion. Thanks for coming back! |
Closing, change approved in the meeting https://www.w3.org/2020/07/21-ag-minutes.html#item05 |
* Updates to the SC text and ripple effects. * Criterion typo * Updated SC in understanding, minor 2.4.7 update * Updates from issue 1055 * Aligned the 'at least' phrases in the SC text. * Update bsaed on 1064 * Updated mode of operation Based on #301 * Adding to the size metric and updating 1st line * Updated understanding to match SC text * Changes from the meeting https://www.w3.org/2020/06/30-ag-minutes.html#item02 * Adding 'discernable' https://www.w3.org/2002/09/wbs/35422/focus-visible-enh-issues3/results#xq4 * Adding fstorr's updates I needed to set this up to merge with the feature branch (rather than master) and my git-fu was no enough, so re-creating. * Renaming focus-vis-eng to focus-appearance-minumum * renaming the focus-appearance understanding doc * Adding Focus Appearance (Enhanced) * Adding technique for focus-appearance-enh * Added AAA to the new stuff section. * mbgowers update * SC updates from #1212 * Removing failures from focus-vis #1067 Co-authored-by: Alastair Campbell <[email protected]>
The second bullet of Focus visible (enhanced) reads:
The phrase 'with colors changed from..." is awkward. Suggest a rewording of:
Change of contrast: Color changes used to indicate focus have a contrast ratio of at least 3:1 with the colors in the unfocused control.
could also make it "...with the replaced colors..."
[updated July 22]
The text was updated successfully, but these errors were encountered: