Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all gulp/postcss dependencies to devDependencies #111

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kfranqueiro
Copy link
Contributor

Currently, this repo's node dependencies (for building CSS) are sprinkled across dependencies and devDependencies, when all of them should arguably be in devDependences - they're required when working within this repo to build CSS, but they're not required by anything externally consuming this repo since the built CSS is already included.

This will avoid compelling external consumers of this repo to install postcss, gulp, and a bunch of plugins.

I tested blowing away node_modules then re-running npm i and npm run build-css to confirm no difference in behavior within this repo.

@kfranqueiro kfranqueiro requested a review from remibetin October 24, 2024 16:06
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for wai-website-theme ready!

Name Link
🔨 Latest commit 609ad51
🔍 Latest deploy log https://app.netlify.com/sites/wai-website-theme/deploys/671a7085ded5b90008908c4b
😎 Deploy Preview https://deploy-preview-111--wai-website-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@remibetin remibetin merged commit f5f6b51 into main Nov 5, 2024
5 checks passed
@remibetin remibetin deleted the kgf-devdependencies branch November 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants