generated from w3c/wai-resource-template
-
Notifications
You must be signed in to change notification settings - Fork 14
Troubleshooting WAI Pull Request Previews
Howard Edwards edited this page Jun 18, 2024
·
3 revisions
This issue is being tracked in wai-aria-practices#219: PRs triggered by aria-practices falling out of sync. The issue is the following:
If there are breaking changes introduced to the main
branch during the lifetime of a generated preview PR, there is a chance it may fail to build on subsequent updates because it does not include the changes required for it to operate as expected, which would be coming from main.
This can be addressed in 2 different ways:
- For the aria-practices pull request, find the matching generated wai-aria-practices pull request to then determine the branch to update. This can be found in any of the following ways:
- You can check the url of the generated preview, where it will be https://deploy-preview-xxx--aria-practices.netlify.app.
xxx
here would also be the matching generated PR number inw3c/wai-aria-practices
list of Pull Requests, so https://github.com/w3c/wai-aria-practices/pull/xxx. The generated branch will be shown for you to then checkout that branch. - The
wai-aria-practices
branch names are generated based on the triggeringaria-practices
PR's branch name that triggered it, with aapg/
prepended to the name. So if thearia-practices
branch's name istesting
, thewai-aria-practices
branch's name would beapg/testing
. You can confirm the matching branch has generated a pull request that's being used inaria-practices
and then checkout that branch.
- You can check the url of the generated preview, where it will be https://deploy-preview-xxx--aria-practices.netlify.app.
- You will then need to merge in the latest changes from
wai-aria-practices
default branch,main
. If there are conflicts, you can opt to just take all the changes from either the generated PR branch ormain
, as the preview build will have to be re-ran. You just want to ensure any breaking preview build changes are captured frommain
.- There is no expectation that there are preview build changes on a generated PR branch as it should only be for serving updated content from the
aria-practices
pull request.
- There is no expectation that there are preview build changes on a generated PR branch as it should only be for serving updated content from the
- After updating the generated PR's branch, the preview link has to be regenerated. This can be done in several ways:
- Check the aria-practices pull request's
Checks
tab and selectTrigger PR update for WAI-APG site
. Re-run the job if you have the appropriate permissions to do so. - Pushing an actual commit or simply pushing an empty commit to the aria-practices pull request to trigger a rebuild with the following git command:
git commit --allow-empty -m "Trigger rebuild"
.
- Check the aria-practices pull request's
- Wait for the new build to complete and it will update the aria-practices top comment as before. Confirm that the expected changes are now present in the generated preview link.
- For the aria-practices pull request, find the matching generated wai-aria-practices pull request to then determine the branch to remove. This can be found in any of the following ways:
- You can check the url of the generated preview, where it will be https://deploy-preview-xxx--aria-practices.netlify.app.
xxx
here would also be the matching generated PR number inw3c/wai-aria-practices
list of Pull Requests, so https://github.com/w3c/wai-aria-practices/pull/xxx. The generated branch will be shown. You can then remove that branch once you have the correct permissions to do so. - The
wai-aria-practices
branch names are generated based on the triggeringaria-practices
PR's branch name that triggered it, with aapg/
prepended to the name. So if thearia-practices
branch's name istesting
, thewai-aria-practices
branch's name would beapg/testing
. You can confirm the matching branch has generated a pull request that's being used inaria-practices
and then remove that branch.
- You can check the url of the generated preview, where it will be https://deploy-preview-xxx--aria-practices.netlify.app.
- After removing the generated branch, the preview link has to be regenerated. This can also be done in several ways:
- Check the aria-practices pull request's
Checks
tab and selectTrigger PR update for WAI-APG site
. Re-run the job if you have the appropriate permissions to do so. - Pushing an actual commit or simply pushing an empty commit to the aria-practices pull request to trigger a rebuild with the following git command:
git commit --allow-empty -m "Trigger rebuild"
.
- Check the aria-practices pull request's
- Wait for the new build to complete and it will update the aria-practices top comment as before. Note that the preview link's url will now be different. Confirm that the expected changes are now present in the generated preview link.