Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For publication / deploy on Thursday December 12, 2024 #372

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

howard-e
Copy link
Contributor

Hi @shawna-slh and @remibetin. We would like to deploy a new version of the APG. This was approved during this week's APG meeting by @mcking65.

The update includes the following, sourced from w3c/aria-practices 2024-12-12 October Publication Pull Requests Milestones and pushed to w3c/aria-practices main branch:

Infinite Scrolling Feed Example: Add fallback foreground color (pull #3150)

By Giacomo Petri on November 2, 2024

Resolves issue #3149 by adding a fallback foreground color of #000 to the body element in the iframe containing the Infinite Scrolling Feed Example. Previously, the foreground color was determined by browser defaults.

View commit ebb4476


Scrollable Listbox Example: Ad default value 'None' so first item can be focusable on load (pull #3139)

By Wagner Maciel on November 19, 2024

Fixes issue #3138 by adding a new value of 'None' to the list of options and focusing that option by default. This makes the example consistent with the pattern guidance.

View commit b0c04c4


Multi-Thumb Slider: Add ability to move thumbs by clicking rail (pull #3172)

By Jon Gunderson on December 11, 2024

Fixed issue #3118.
Updates the multi-thumb slider so clicking the rail moves one of the thumbs. The thumb closest to the click is moved.
Also updates javascript code style to use const and let instead of var.

View commit d93a99a

@howard-e howard-e requested a review from shawna-slh as a code owner December 12, 2024 00:47
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit 9343ecc
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/675a329ca2fa510008245402
😎 Deploy Preview https://deploy-preview-372--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@shawna-slh shawna-slh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shawn defers process and content review to @daniel-montalvo and high-level QA to @remibetin
Thanks!

Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@remibetin remibetin merged commit 46448c3 into publication Dec 12, 2024
7 checks passed
@remibetin
Copy link
Member

@howard-e Published. Please QA.

cc @daniel-montalvo

@howard-e
Copy link
Contributor Author

Thanks @remibetin @daniel-montalvo. The changes seem good to me!

cc @mcking65 @a11ydoer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants