Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APG -> WAI pipeline workflows #361

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Sep 30, 2024

Supersedes #353.

This PR addresses the following:

  • PRs triggered by aria-practices falling out of sync #219 by forcing a rebase for the generated branch on main. Most likely changes to any "infrastructure" files. It shouldn't matter if changes are discarded on the branch because the site rebuild updates the static content on each new commit anyways (or attempts to).
  • Reflect more localized errors, and with additional details.
  • Proposal for wai-aria-practices to explicitly provide a commit status for a recently updated PR in aria-practices so contributors can better understand that a build failure has happened (currently, scanning the top comment for "WAI Preview Link failed to build" is the only way now).
  • Rename create-pr script folder to pr-create for consistency.
  • Update outdated dependencies.
  • Update outdated GitHub Actions.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit 5f37f14
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/674f338df29e6f0009d8cf55
😎 Deploy Preview https://deploy-preview-361--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e howard-e requested a review from stalgiag October 16, 2024 13:40
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I verified that the demonstrated tests worked well and the force rebase solves the issue. Thanks for this @howard-e

} catch (e) {
console.error('error.create.commit.status', e);
process.exit(ERROR_CREATE_COMMIT_STATUS);
}*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@howard-e howard-e merged commit 9bc78c8 into w3c:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants