-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update APG
-> WAI
pipeline workflows
#361
Conversation
…e generated branch doesn't have relevant changes; additional error handling coverage with create-pr script
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I verified that the demonstrated tests worked well and the force rebase solves the issue. Thanks for this @howard-e
} catch (e) { | ||
console.error('error.create.commit.status', e); | ||
process.exit(ERROR_CREATE_COMMIT_STATUS); | ||
}*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Supersedes #353.
This PR addresses the following:
main
. Most likely changes to any "infrastructure" files. It shouldn't matter if changes are discarded on the branch because the site rebuild updates the static content on each new commit anyways (or attempts to).wai-aria-practices
to explicitly provide a commit status for a recently updated PR inaria-practices
so contributors can better understand that a build failure has happened (currently, scanning the top comment for "WAI Preview Link failed to build" is the only way now).create-pr
script folder topr-create
for consistency.