Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate the requirements for wide review #130

Closed
nigelmegitt opened this issue Nov 7, 2017 · 145 comments
Closed

Enumerate the requirements for wide review #130

nigelmegitt opened this issue Nov 7, 2017 · 145 comments
Assignees
Milestone

Comments

@nigelmegitt
Copy link
Contributor

I've observed that there is confusion about what constitutes a good wide review. It would be helpful to clarify in the Process the minimal requirements for processing review feedback, for example to match the good practice that was embedded in the old disposition of comments tool, namely:

  • Announce by public notification and external liaison that must include the relevant groups listed in the Charter:
    • the review period,
    • the scope of the review being requested, and
    • the process for providing review feedback.
  • Agree a WG disposition for each comment
  • Send the WG disposition to the commenter (can have a latest response deadline not sooner than 2 weeks later)
  • Record the commenter's response if any within the deadline

This is minimal - obviously groups that enter into discussions with the commenter and can document a conversation in which the WG and the commenter arrive at a mutually acceptable conclusion would satisfy these requirements.

@nrooney
Copy link
Contributor

nrooney commented Jan 17, 2018

Read and understood. Will discuss at next CG meeting.

@dwsinger
Copy link
Contributor

taking up, and we should clarify if this is practice or process

@jeffjaffe
Copy link

It is certainly a problem that chairs do not know what the minimum requirements are. In the past, people have wanted this treated as a practice rather than a process so that the Director might apply judgment in individual cases. But if chairs are totally confused, it might make sense to make this into a process issue.

@nigelmegitt
Copy link
Contributor Author

By the way, since I raised this, it's become clear that horizontal review is considered to be a subset of wide review, so that needs to be brought into scope.

Additionally, I think that other W3C groups that are listed in the WG's Charter as dependencies also need to be notified.

One more point: there's some confusion about whether wide review is needed to enter CR, to exit CR, or both. The usual practice and expectation is that it is required in order to enter CR, but the Process clearly states that it is also required in order to enter PR. The ambiguity here is whether or not the same wide review can be used for entering CR and PR; since a spec cannot get to PR except from a CR, by definition all specs must have demonstrated wide review already. So why require it again explicitly for PR? Is it supposed to be a wide review of any deltas between the intended PR and the CR?

@dwsinger
Copy link
Contributor

I think concrete suggestions to help clarify would be very welcome.

@LJWatson
Copy link
Contributor

I think Section 6.2.3.1 has most of the information, but it's just not written in a way that's easy to parse.
The broad topics I think this section needs to cover, are:

  • What is a wide review/why is it sought
  • When should wide review happen
  • Who should be invited to participate/how should they be notified
  • What should be done with the resulting feedback

If we can get some agreement around the high level points, I'll take a run at some words.

@nigelmegitt
Copy link
Contributor Author

@LJWatson Yes, and I'd expand "what should be done with the resulting feedback" a bit to include the follow-up step with the commenter, in other words:

  • how can the end of wide review be identified?

and add:

  • What information about the wide review needs to be reported?

I don't agree that Section 6.2.3.1 has most of the information. That section currently describes the objectives of the Wide Review, which is definitely worth doing, but it does not address your summary bullet points. I think the edit needed is mainly additive rather than a change to the existing words.

@dwsinger
Copy link
Contributor

I agree, the distinction between the review per se, and the consequent discussion, and possible action, may need to be clearer. The discussions can be effectively interminable; but the group needs to get past the milestone. Advice on how to handle that would be good.

@michaelchampion
Copy link

I don't know where to draw the line between formal Process and guidance on how to implement the policy in a way that will satisfy the Director. But from watching the pain chairs go through, it seems to me that wide review needs to be less labor intensive to track and quicker to conclude. That said, "wide review" is one of the features that distinguish W3C Recommendations from lighter-way alternative ways to define specs, so finding the right balance is critical.

Things I'd like to see in the process or guidance:

  • Shipping is a feature! Accept that even Recommendations are not final; review feedback that doesn't get incorporated into this release can be considered in the next, so don't delay publishing a good spec in hopes of publishing a perfect spec.
  • Feedback goes to where the chairs/editors say it should go, not to where the reviewers prefer. In practice that probably means a single GitHub issues list for the spec being reviewed, not the mailing lists or issues lists of the various horizontal groups.
    -Editors do have some responsibility to explain how they responded to review feedback, but requirements requirement to contact the reviewers to ask whether they are satisfied with the response seems excessive. If reviewers don't like the disposition they can re-open an issue, escalate to the chairs/team contact/Director, file a formal appeal, etc.
  • Each community is different, so I would give WG chairs/team contacts a fair amount of discretion on how to get useful reviews from the right experts.

@nigelmegitt
Copy link
Contributor Author

Editors do have some responsibility to explain how they responded to review feedback

Why "Editors"? I think this is a WG responsibility.

requirement to contact the reviewers to ask whether they are satisfied with the response seems excessive. If reviewers don't like the disposition they can re-open an issue, escalate to the chairs/team contact/Director, file a formal appeal, etc.

@michaelchampion I disagree - it is too onerous on external individuals and organisations to force them around this loop, and it is courteous to conclude the conversation that they began. It is also useful information if they agreed or disagreed with the WG's disposition, since the Director can rapidly filter out the "agreed"s and focus only on the "disagreed"s which is where the attention is likely needed.

@michaelchampion
Copy link

The question I'm asking is whether we want to make it onerous for chairs / editors to process feedback at the cost of making the standards process slow and bureaucratic or to make it more onerous for external reviewers to track the resolution of their issues and contest the WG / editor resolution.

I see a lot of work that once might have gone to W3C being done in WHATWG or open source projects that operate by "lazy consensus" http://en.osswiki.info/concepts/lazy_consensus. They give editors / committers clear ownership, and puts the burden on reviewers who don't agree to speak up and make their case to do something different.

But I agree it's a difficult balance to strike -- a value of W3C standards over those from some more agile organizations is a broad base of stakeholders who have given specs wide review. High quality input from external experts who will engage to make their case is definitely valuable, but such reviewers are generally happy to engage directly in the WG's issues list in my experience.

@dwsinger
Copy link
Contributor

dwsinger commented Feb 28, 2018 via email

@nigelmegitt
Copy link
Contributor Author

High quality input from external experts who will engage to make their case is definitely valuable, but such reviewers are generally happy to engage directly in the WG's issues list in my experience.

@michaelchampion Sometimes they do, but often they do not: a lot of feedback comes my way from other standards organisations representing a constituency who are giving collective feedback with the goal of adopting/referencing W3C standards within other specifications. Their preferred engagement model is much more ponderous, and consists of liaison messages. Obviously where possible we do try to engage more directly, but members of other standards organisations do not always want to come out in the open.

@LJWatson
Copy link
Contributor

LJWatson commented Mar 2, 2018

I've taken a first pass at some words. My hunch is that this is guidance rather than process, even assuming it captures what we hope it will. In the interests of having something concrete to work with though...

the purpose of a wide review is to seek feedback on a document from the entire web community, including the general public. The goal is to make the document as robust as possible before it becomes a Recommendation.

A wide review can be conducted at different stages of a document's maturity. Depending on the reason for the wide review, the set of stakeholders may vary.

As a minimum, a comprehensive wide review should be conducted as the document prepares to transition to Candidate Recommendation. At this stage a wide review request should be sent to the following stakeholders:

  • The Working Group responsible for the document
  • The liaison Working Groups documented in the Working Group's charter
  • Other?

In addition, a notice should be sent to [insert email here].

A wide review can also be conducted at the following times:

  • When the First Public Working Draft is published
  • Whenever an updated Working Draft is published
  • Other?

To facilitate wide review, a document should have a log of changes made since its previous publication on TR.

Issues raised as a consequence of a wide review should be filed on the Github repository for the document. This streamlines the management of issue discussion and resolution, and makes sure the person or organisation that files the issue is informed of its progress.

@dwsinger
Copy link
Contributor

dwsinger commented Mar 2, 2018

It's a start, but I think the hard questions are around "what is a review? when is it complete? what level of reaction is needed? how much response is needed? how much consensus with the commenter is needed? can review to-and-fro be allowed to drag on forever? can deadlines be put on the stages? how much documentation trail is needed? are tagged GH issues good enough?"

@nigelmegitt
Copy link
Contributor Author

The Process shouldn't say where issues should be raised because it's a WG decision about how to work and what tools to use. However the SOTD in the document being reviewed must do so I think. If it's not already a requirement then it needs to be made one.

The "other" stakeholders need to include any external liaisons registered as having an interest in the topic (see Liaisons for the list) or listed in the WG's Charter, and the general public, as notified minimally on the w3.org homepage but also by any other W3 communications channel such as twitter, RSS etc.

I'm slightly troubled by the idea of differing sets of stakeholders for wide review depending on maturity level. It would be simpler to have one process that is wide review, and reuse it wherever needed.

For what it's worth, my pet name for a review process that only goes to other W3 groups is "narrow review".

@dwsinger
Copy link
Contributor

Team is working on this and we expect a proposal

@wseltzer
Copy link
Member

@swickr can you share updates from your conversations with i18n and a11y?

@frivoal frivoal added the DoC This has been referenced from a Disposition of Comments (or predates the use of DoCs) label Feb 7, 2019
@frivoal frivoal added this to the Process 2020 milestone Feb 19, 2019
@frivoal frivoal removed this from the Process 2020 milestone Feb 19, 2019
@dwsinger
Copy link
Contributor

We create a separate normative document that describes what is required for wide and horizontal review (when, how, and what etc.).

We include some concise information in the Process that links to the normative requirements and makes it very clear that they are indeed required.

I think that this is sufficiently similar to what others and I have proposed — that we tersely state the normative requirements in the process, and link to a Guide document that is more helpful to read — that we'll need to work out whether we can do this separation cleanly as I hope, or have normative statements outside the process. The advantage of the second document bding a Guide is that its update process can be relaxed; unlike say CEPC, which because it's normative we subject to W3M, ASB, and AC scrutiny, we could have a lighter hand.

I doubt we'll find out which approach can be made to work without trying, though.

@LJWatson
Copy link
Contributor

LJWatson commented Jul 14, 2020 via email

@cwilso
Copy link
Contributor

cwilso commented Jul 14, 2020

I would not be okay with an approach that made novel requirements stated in /Guide (and thus outside the jurisdiction of the Process, and the AB/AC) normative. Any normative requirements must go through the same process as updates to the Process itself, or there is no escalation path.

@dwsinger
Copy link
Contributor

dwsinger commented Jul 14, 2020

re:

It is the balance of separation that is important I think. If the requirements documented in /Guide can be considered normative, and the Process can normatively state that they must be followed, I would be ok with that approach.
Otherwise I feel strongly that the Process itself needs to be unequivocal about the requirements.

I am truly hesitant to do the former; linked documents that are normative have to go through much greater scrutiny. I think we should try to do the latter instead: normative requirements tersely stated in the process, and an informative and readable guide that introduces the tooling, best practices, considerations, and so on, and is actually helpful; and because it's informative, it can be easily updated without W3M, AB, AC and Director review and formal approval.

If we fail on this separation and determine it can't be done, then I'll grudgingly consider a linked document with normative requirements...

@LJWatson
Copy link
Contributor

@cwilso I agree, but unless I misunderstood @plehegar, the Process already links to external documents that are themselves considered normative, and that as I understand it means they've gone through the usual motions.

@aphillips
Copy link

I think there is Process and then there is process. The normative bits should go in the Process doc--you have to get HR within such-and-such time (e.g. the putative 60 days) and either resolve issues to the satisfaction of the HR group (which can include deferring the issue) or be prepared to document the dispute at transition time. Etc.

I think these can be fairly succinct declarative statements.

And then there are the minutiae of conducting HR: where to file requests, how to label issues, where to look for tooling, where to get self-review checklists, when to do review, etc. That sort of thing probably belongs in the Guide and doesn't probably require W3M/AB/AC/Director scrutiny. It's a Best Practices document that borders on normative (lots of SHOULD, reserving MUST for things found in the Process). A WG would not be well-received if they hewed to the requirements of the Process but ignored the best practices.

@michaelchampion
Copy link

michaelchampion commented Jul 14, 2020

It might be useful to think about the questions the various process-related documents address:

  • WHY are we doing what we do? (member agreement, eventual bylaws of W3C Inc.?)

  • WHAT does success look like and what are the principles, requirements, and constraints that must be respected before declaring success? (Process Document?)

  • HOW do things work in detail given the current cultural norms and state of the art? (/Guide ?)

@LJWatson and @plehegar it's apparently true that the Process today links to normative documents that are not subject to a community-wide consensus process. I think that's a bug not a feature. Or perhaps that it's a feature of a Director-controlled community in which the Director can delegate the implementation details but is ultimately responsible for them just as they[*] are ultimately responsible for declaring consensus . Either way, it's not sustainable going forward.

[* ]Both a gender-neutral singular reference to the current nominal Director and a plural reference to the W3M consensus that seems to be the de facto Director today.

@LJWatson
Copy link
Contributor

I am truly hesitant to do the former; linked documents that are normative have to go through much greater scrutiny. I think we should try to do the latter...>

I'm beginning to think we're going around in circles.

The reason for the proposed text was to address feedback that the requirements for wide/horizontal review were not clear, were not mandated, and were consequently not happening properly.

I think the proposed text addresses the first two parts of that feedback, and will hopefully realise the third.

But there have been requests to move requirements out of the Process and requests to keep it in; requests to make the requirements more specific and requests to make it more vague, and somewhere in the background we've touched on the wider intent to streamline the process as a whole.

I'm exhausted.

@plehegar
Copy link
Member

one note on this: /Guide on wide review was refreshed and there is now https://www.w3.org/Guide/documentreview/

@LJWatson
Copy link
Contributor

Thanks @plehegar .

Question to everyone on this thread... Now this guidance exists, does it impact what should/should not go into the process, and if so, how?

@dwsinger
Copy link
Contributor

dwsinger commented Jan 6, 2021

we need specific wording, ideally a Pull Request, please, if any changes need to be made for P2021

@dwsinger
Copy link
Contributor

dwsinger commented Jan 6, 2021

(We could also improve the Guide material)

@dwsinger
Copy link
Contributor

dwsinger commented Jan 6, 2021

The problems to solvce include at least

  • horizontal groups being called in late
  • editors and chairs not knowing what to do to satisfy the requirement

@fantasai
Copy link
Collaborator

fantasai commented Jan 6, 2021

We think the new /Guide document helps with these, and it's not entirely clear what text would need to be added to the Process other than what's there to support it. If something is needed, we need a more specific suggestion.

@nigelmegitt
Copy link
Contributor Author

Now this guidance exists, does it impact what should/should not go into the process, and if so, how?

Yes. Several of the minimal requirements I suggested in this issue are still undocumented, and I'm not clear whether that's because they're optional, or stated some other place, but I don't see them in the Guide or the Process.

Specifically the required handling of comments is not documented. Something along the lines of (quoting myself):

  • Agree a WG disposition for each comment
  • Send the WG disposition to the commenter (can have a latest response deadline not sooner than 2 weeks later)
  • Record the commenter's response if any within the deadline

I raised w3c/guide#276 to capture this somewhat. My view is that it would be better for the minimal requirements to be documented in the Process, and additional good practices to be documented in the Guide. If I've understood correctly, there is no minimal requirement on comment handling in the Process, but there is a historical expectation that things will be done with an appropriate level of formality, in order to demonstrate the review has been completed.

I'd like to see all WGs work to the same rules here, and that means defining something in the Process, even if that something isn't very detailed.

@fantasai
Copy link
Collaborator

@nigelmegitt I believe the requirement to handle comments is already covered by the combination of these two sections:
https://www.w3.org/2020/Process-20200915/#doc-reviews
https://www.w3.org/2020/Process-20200915/#formal-address

@nigelmegitt
Copy link
Contributor Author

@fantasai thank you, yes, and apologies for the noise caused by my not noticing those sections previously. I withdraw my comment that "handling of comments is not documented" (with some embarrassment!). If there are no other unresolved comments on this issue, then, having raised it, I'd be happy to close it, or for someone else to.

@dwsinger dwsinger removed the Needs AB Feedback Advisory Board Input needed label Feb 10, 2021
@LJWatson
Copy link
Contributor

Why has this been closed?

@dwsinger
Copy link
Contributor

closed because we thought it was covered in all the /Guide updates and no more process CG action was needed. If you disagree, can you either re-open and say why, or file new issues?

@TallTed
Copy link
Member

TallTed commented Mar 25, 2021

@dwsinger @LJWatson -- I think it worth noting that the person who raised the issue (@nigelmegitt) believed it had been resolved, so it was ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests