Feature/review tr styles #155
Open
+32
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove number from contextual text, as it seems of minimal benefit to people - Visually hide contextual text in TR translations <dt>, leaving it available for screen reader users - Add CSS to compensate for blank inline space created by visuallyhidden text
NicolaSaunders
requested review from
jean-gui,
deniak,
vivienlacourba and
gosko
vivienlacourba
requested changes
Oct 14, 2024
design-system-templates/components/tr-search-results-family.html.twig
Outdated
Show resolved
Hide resolved
deniak
approved these changes
Oct 15, 2024
Co-authored-by: Denis Ah-Kang <[email protected]>
Co-authored-by: Denis Ah-Kang <[email protected]>
vivienlacourba
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for w3c/w3c-website#207
<dt>, leaving it available for screen reader users<dt>