Skip to content

Commit

Permalink
Rename testAllImplementers to testAllImplementations.
Browse files Browse the repository at this point in the history
Matches what actually is happening...and what I kept typing...
  • Loading branch information
BigBlueHat committed Apr 2, 2024
1 parent a16f7ea commit 97a894b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Additional test suite runtime configuration can be done via the `settings` key
in a `localConfig.cjs`. The current global settings are:

* `enableInteropTests` - enable/disable the cross-implementation "interop" tests
* `testAllImplementers` - enable/disable testing _all_ implementations (not
* `testAllImplementations` - enable/disable testing _all_ implementations (not
just what's in `localConfig.cjs`)

Both of these settings are `false` when `localConfig.cjs` is present, but may be
Expand All @@ -147,7 +147,7 @@ module.exports = {
"settings": {
// overriding the default, false, for local testing
"enableInteropTests": true,
"testAllImplementers": true
"testAllImplementations": true
},
"implementations": [{
"name": "My Company",
Expand Down
8 changes: 4 additions & 4 deletions implementations/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ const localConfig = getLocalManifest('localConfig.cjs');
export const localSettings = (Object.keys(localConfig).length > 0) ?
// we have a localConfig object, so merge in local defaults
{...localConfig?.settings,
...{enableInteropTests: false, testAllImplementers: false}} :
...{enableInteropTests: false, testAllImplementations: false}} :
// otherwise, return the global defaults
// FIXME: ...consider renaming `localSettings` as it can hold global ones...
{enableInteropTests: true, testAllImplementers: true};
{enableInteropTests: true, testAllImplementations: true};

// get localConfig and look for an implementations property
const local = localConfig?.implementations || [];
Expand All @@ -44,6 +44,6 @@ const all = remote.concat(local);

// if local implementations are defined only return local implementations
export const implementerFiles = local.length ?
// unless testAllImplementers is true...in which case, include them all
(localSettings.testAllImplementers === true ? all : local) :
// unless testAllImplementations is true...in which case, include them all
(localSettings.testAllImplementations === true ? all : local) :
all;

0 comments on commit 97a894b

Please sign in to comment.