-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relatedResource
property to VerifiablePresentation
#1370
Conversation
index.html
Outdated
</p> | ||
<p class="issue" title="Mandatory listing of contexts in relatedResouce are under debate."> | ||
The requirement that contexts be listed in `relatedResource` is currently being | ||
debated in the VCWG. This requirement might be removed in future iterations of | ||
the specification. | ||
</p> | ||
<p class="issue at-risk" title="Use of `relatedResource` in `VerifiablePresentation`"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p class="issue at-risk" title="Use of `relatedResource` in `VerifiablePresentation`"> | |
<p class="issue at-risk" title="Use of `relatedResource` in `VerifiablePresentation` is at risk"> |
I think it is better to make the "at risk" features very explicit when reading the document. (I have not checked whether this is the case for the other, at risk features in the spec.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! 😀
relatedResource
property to VerifiableCredential
relatedResource
property to VerifiablePresentation
@@ -163,7 +163,7 @@ property: | |||
|
|||
- id: relatedResource | |||
label: Related resource | |||
domain: cred:VerifiableCredential | |||
domain: [cred:VerifiableCredential, cred:VerifiablePresentation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry, I meant for this comment to go on "range".
Given this points to credentials by URL, which can't you use a Data URI here?
{
"@context": [
"https://www.w3.org/ns/credentials/v2",
"https://www.w3.org/ns/credentials/examples/v2"
],
"id": "urn:uuid:5ec137ea-871e-11ee-a783-ef96a4397a9a",
"type": ["VerifiablePresentation", "ExamplePresentation"],
"relatedResource": [
"https://vendor.example/resources/42",
"data:application/jwt;base64,QzVjV...RMjUK==",
"data:application/cwt;base64,ZmlOW...pYzMK="
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because an enveloped credential is far more that just a "related resource".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be concerning to me to use this property to represent jwts/cwts that are transformable to w3c vcs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decentralgabe, would you find this mechanism more acceptable? #1379 (preview here)
<code>relatedResource</code> is present, there MUST be an object in the array | ||
for each remote resource for each context used in the verifiable credential. | ||
for each remote resource used in the verifiable credential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data URIs are IRIs.
This is still a layering error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this. It isn't a good adjustment.
The issue was discussed in a meeting on 2023-12-05
View the transcript1.1. Add
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not go in. It's a layer violation.
@jandrieu wrote:
You noted on the call that you were a non-blocking objection for this PR. However, your comment above could be seen as objecting to this PR. Are you ok with it being merged, or are you objecting to it being merged? |
That was a miscommunication. I do object to this going in. |
@jandrieu wrote:
Ok, marking this as pending close, then. |
The issue was discussed in a meeting on 2023-12-12
View the transcript2.1. Add
|
PR failed to achieve consensus, marked "pending close" for over a week, closing. |
This PR attempts to address issue #1360 by allowing the
relatedResource
property to be used on aVerifiablePresentation
. It also adds an "at risk" issue marker noting that the feature might be removed in the Candidate Recommendation phase based on implementer feedback.Preview | Diff