Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison to NIST definition #1332

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Oct 31, 2023

Addresses: #1047

terms.html Outdated Show resolved Hide resolved
terms.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Nov 1, 2023

The issue was discussed in a meeting on 2023-11-01

  • no resolutions were taken
View the transcript

1.1. Add comparison to NIST definition (pr vc-data-model#1332)

See github pull request vc-data-model#1332.

Brent Zundel: there are two recently opened to take a look at now.
… Adds a comparison to the NIST definition of credentials. Adds a sentence that says its different than the NIST definition. Comments?

Manu Sporny: +1 to straightfoward PR -- would like some editorial changes there, but nothing blocking.

terms.html Outdated Show resolved Hide resolved
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IFF @dlongley's suggested change is applied.

@iherman
Copy link
Member

iherman commented Nov 14, 2023

The issue was discussed in a meeting on 2023-11-14

  • no resolutions were taken
View the transcript

1.5. Add comparison to NIST definition (pr vc-data-model#1332)

See github pull request vc-data-model#1332.

Brent Zundel: there was one change request on this one, which folks seemed fine with. I think we are waiting on Orie to respond.
… I will ping Orie directly to ask him to respond (he is not available for these Tuesday calls).

Joe Andrieu: seems like there was reasonable consensus to remove that last line, but I do think it is appropriate to bring in Orie on this one.

Sebastian Crane: +1 to JoeAndrieu (IRC) - I think we have consensus. Can we note this for Orie's benefit?

Brent Zundel: I think there is broad agreement on this one if the recommended change is made.

Co-authored-by: Dave Longley <[email protected]>
@OR13
Copy link
Contributor Author

OR13 commented Nov 15, 2023

I believe all suggestions have been applied.

@brentzundel
Copy link
Member

non-normative changes, open for review for several weeks, requested changes applied, merging

@brentzundel brentzundel merged commit 8322a96 into main Nov 15, 2023
1 check passed
@@ -11,6 +11,10 @@
<dd>
A set of one or more <a>claims</a> made by an <a>issuer</a>.
The <a>claims</a> in a credential can be about different <a>subjects</a>.
<p>
Our definition of credential differs from,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange place for a comma...

Suggested change
Our definition of credential differs from,
Our definition of credential differs from

@msporny msporny deleted the feat/define-credential-better branch December 17, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants