-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confidence method to VCDM #1054
Conversation
…rmation method is defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language and punctuation fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great direction - would like removal of liability mentions
I believe everything from that list should be addressed. Please approve if this is the case. I also updated the reworded the commit messages for all "update index.html" commits as requested. |
On a different point, |
I submit that @msporny mis-typed. It's still not about binding. Credentials are inherently about particular subjects, however they are identified. So far as I can tell, |
The issue was discussed in a meeting on 2023-05-10
View the transcript1.1. Add confidence method to VCDM (pr vc-data-model#1054)See github pull request vc-data-model#1054. Manu Sporny: Confidence method PR - there seemed to be consensus to merge last week but Orie had some objections. Wondering what we're doing with it? Orie Steele: concerned with this PR - calling it confidence methods is confusing and invites degraded security characteristics but doesn't work across industries. There aren't yet two independent implementations yet. Brent Zundel: other comments? Manu Sporny: To untangle things, one reason to put reserved property in the spec is to acknowledge important work. While Orie is the -1 in the voting but these objections need to be addressed.
Manu Sporny: in the render method spec made it its own specification and defined the normative property of render method in that separate text. Could follow that path for this confidence method mechanism, without txt in the core spec.
Manu Sporny: what specific things will break if we put this into the specification? Need more details beyond concerns to understand how to respond. Michael Prorock: likes manu's approach to create an independent spec. This gets it out of the core spec, do the work in CCG, and bring it back when it's ready.
Brent Zundel: concerned that we sounded like agreement last week and now we sound differently.
Dave Longley: fine with the approach manu has suggested making it a separate spec. The new argument is combining it with confidence associated with "man" but we should proceed with Manu's plan. Brent Zundel: clarifying which plan?
Dave Longley: add property to reserve table and can add it to the main spec later. If the group doesn't want that at risk text in the spec he could live with it as well.
Brent Zundel: "At risk" has a specific meaning. It's not common to use "at risk" in specifications at this stage.
Manu Sporny: based on the minutes from the last call we had agreement to bring the defs into the spec. We could poll to see if preference is to include in the spec as "at risk" or move it out to an external thing. Michael Prorock: not a fan of this at this point. But he's not going to block this at this stage. Strong preference to do the work elsewhere an not a fan of "at risk" in the language.
Ted Thibodeau Jr.: last week we did take into account the W3C meaning of "at risk". We were going to list both in table of reserve terms and in the implementation section. whichever one won out would stay in the spect the other removed.
Ted Thibodeau Jr.: same is true in reverse. Could lie fallow for a period of time and be addressed later.
Ted Thibodeau Jr.: the use of confidence man should not impact the meaning of confidence. That objection has no utility for me.
Orie Steele: clarifying why confidence is problematic -it's a predicate in JSON-LD. It's an open RDF cookie and could allow adding a confirmation type of sending a person to a home (physically). Not a good idea to have any RDF type.
Orie Steele: legit to have a technical means to have a binding, but a vocab that invites people to do whatever they want isn't appropriate. Dislike word "confidence" he's amenable for a separate path forward.
Brent Zundel: let's do some polls.
Manu Sporny: asks Brent to craft something.
Brent Zundel: poll open.
Ted Thibodeau Jr.: clarification "removed form the spec and left in the reserved table". Brent Zundel: Orie's -1 is noted. Shigeya Suzuki: wondering if this method may increase confusion. People in this call understand there are different camps. The people who lead this spec might confuse this with the "confidence method". Brent Zundel: poll makes it clear we don't have consensus and we'll continue talking about it. Manu Sporny: should it be marked as "do not merge" and move on?
Brent Zundel: label it "discusss". |
@OR13 after reading the minutes, I can see you have the following concern:
I don't think that this is a valid concern since the W3C VCDM has taken that approach with other extension points as well. For instance, I could define a status method that requires the verifier to call an expensive phone number, or to send a text message with the verifier's home address, so the issuer sends somebody to the verifier's home. @OR13 what is the difference between these two? Why is the W3C VCDM extensibility model not appropriate for confidence method? |
@awoie you don't need to make changes to this TR to take advantage of the extensibility model of JSON-LD. I think it is unsafe to define |
Validating the binding between the claims and the presenter would then require to understand whether the specific securing mechanism has support for that since on the VCDM layer this won't be visible. This would have to be implemented on a different layer in that case. It would also mean that some securing mechanisms are more prone to certain attacks or at least less suitable for online presentation protocols since they don't have that feature. I can see your point and I can see that this can be, indeed a feature of the securing mechanism and effectively on a different layer. In that case, I would add at least a security considerations section to the VCDM that talks about replay / forgery / cloning concerns and that implementer's should be aware of that and choose securing mechanisms accordingly. I'll create an issue for that. I believe we had some ticket on relay but we closed it. This issue is less about relay, more about replay / cloning although relay is related. I don't understand your comment on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that this would be better handled in a separate specification and not as a part of the core data model
I would suggest adding in a similar way to render method. Furthermore, I'll create issues in the security considerations section to highlight that certain things are not prevented when the VCDM is used without additional securing mechnisms. |
I asked @swcurran and @paulbastian here for their opinion. I suggest if there is no objection in the next 2 weeks, we can close this PR. |
It has been proposed that we close this PR in favor of another path forward. I have added the label |
I'd like this to remain open until the context is in fact updated. There are too many arguments over what should and shouldn't be in the context for this to be removed before we have consensus on including it in context. |
I don't think we should leave PRs open, that we have no intention of merging... that is what issue markers are for. I suggest raising a PR to add an issue marker to the spec, and then closing this. |
Given:
This PR should be closed, the PRs above can remain open until they achieve consensus. |
Correct order:
|
Closing this PR since this work was transferred to CCG. |
Potentially fixes #789, #882
This PR includes normative changes that define a new property
confirmationMethod
(aka holder binding):Out-of-scope:
Preview | Diff