-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify section on verifiable credential graph #1365
Comments
@andresuribe87 Can you please be more specific about the sort of "clarification" you're seeking? While everything @iherman says above is accurate, I'm not sure it helps readers. IOW, we're re-explaining concepts that other specifications explain (like RDF Concepts), or the details are not pertinent to the understanding of implementing VCs. I don't know if you're requesting a few sentences of clarification, and if so, what specifically? Or you're requesting the depth of explanation @iherman provided to you, which I don't agree is helpful to put in the specification for at least two reasons: 1) those concepts are covered in other specifications; duplicating content is generally frowned upon, and 2) it's not clear how these clarifications impact anyone using or implementing the system? |
@msporny here are some more concrete clarifications that I think are the minimum necessary. Within the section 4.9, state that "An externally secured verifiable credential is not considered a verifiable credential graph. In general, a URL is only considered a verifiable graph when dereferencing the value results in a conformant document according to this data model.". Within the definition of Presentations, in the |
Seems like making it clear that IRI is included in the range of |
The issue was discussed in a meeting on 2023-12-06
View the transcript2.5. Clarify section on verifiable credential graph (issue vc-data-model#1365)See github issue vc-data-model#1365.
Brent Zundel: andres, is this before or post-CR? Andres Uribe: I think this should be before CR. Brent Zundel: Who's willing to be assigned? Manu Sporny: I am willing to be assigned. |
@andresuribe87 wrote:
Great, thank you for the concrete suggestions, very helpful. I'm going to get super pedantic here because it'll affect the language that's written. To be clear, I want to write some variation of the language you suggested as long as it's accurate:
While an externally secured VC couldn't be directly considered to be a separate graph (in most cases), it could be expressed in a separate graph, which is what PR #1379 does. There is probably also some language that we could create where one could pre/post-process it and /interpret/ it as a verifiable credential graph... but that would just add complexity for the sake of academic purity. I'm not sure that language would benefit the vast majority of VC authors.
This sounds true on the surface... I'm trying to think about how this might be mis-interpreted. Developers might think that they can start stuffing URLs in the
This is true, but then people might think they can't do what's in PR #1379. I guess I'm trying to figure out if PR #1379 changes any of your suggestions? I think what you're trying to say is "ban the use of pure strings and URLs in the |
#1379 does not change my suggestions. It helps provide clarify, but I don't think it's enough.
Yes. That's it. I want to provide clarity to implementers on what is and what isn't allowed as a value of the |
"MUST be an object; i.e., it can't be any non-object, particularly including..." |
The issue was discussed in a meeting on 2023-12-13
View the transcript2.12. Clarify section on verifiable credential graph (issue vc-data-model#1365)See github issue vc-data-model#1365. Brent Zundel: clarify section of verifiable credential graph. Manu Sporny: there is a clear concern, which i think I can address.
Brent Zundel: do you want to mix that into 1379? Manu Sporny: seems to make sense to put it in 1379. See github pull request vc-data-model#1379. Brent Zundel: then it will address that issue as well. |
The issue was discussed in a meeting on 2023-12-20
View the transcript4.2. Clarify section on verifiable credential graph (issue vc-data-model#1365)See github issue vc-data-model#1365. Brent Zundel: 1365 Clarify section on VC graph. Has PR 1390. Status: wide array of approvals, some ed. Most likely to be merged soon. Then will close. |
PR #1390 has been merged, closing. |
From #1358 (comment) it's become evident that we need to further clarify what a "verifiable credential graph" is. Excerpt from the conversation is paster below.
The text was updated successfully, but these errors were encountered: