Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need resourceIntegrity in vocab and under w3c #193

Closed
mprorock opened this issue Jun 13, 2023 · 6 comments
Closed

need resourceIntegrity in vocab and under w3c #193

mprorock opened this issue Jun 13, 2023 · 6 comments
Assignees
Labels
ready for pr This issue is ready to be resolved via a pull request

Comments

@mprorock
Copy link
Contributor

per pr w3c/vc-data-model#1140 need resourceIntegrity in the the right spots in vocab, etc.

@OR13 for more color commentary if needed

@Sakurann Sakurann added the ready for pr This issue is ready to be resolved via a pull request label Jul 5, 2023
@iherman
Copy link
Member

iherman commented Jul 6, 2023

The issue was discussed in a meeting on 2023-07-05

  • no resolutions were taken
View the transcript

2.1. need resourceIntegrity in vocab and under w3c (issue vc-data-model#1152)

See github issue vc-data-model#1152.

Manu Sporny: This is definitely pre-candidate rec.

Michael Prorock: I'm fine raising the PR. I may be delayed two weeks due to travel.

@OR13
Copy link
Contributor

OR13 commented Aug 30, 2023

@iherman perhaps you can assist?

@iherman
Copy link
Member

iherman commented Sep 3, 2023

The issue was discussed in a meeting on 2023-08-30

  • no resolutions were taken
View the transcript

4.1. need resourceIntegrity in vocab and under w3c (issue vc-data-model#1152)

See github issue vc-data-model#1152.

Brent Zundel: Raised by Mike Prorock. Ready for PR.

Michael Prorock: I thought we were going to get some guidance from Ivan, but maybe I'm misremembering.
… it's ready for PR. I'll try to get to it.

Sebastian Crane: is this the same a w3c/vc-data-model#1261.

Manu Sporny: no.

Brent Zundel: no.

Michael Prorock: no. different.

Manu Sporny: This should be an easy one -- fairly straight-forward PR.

Brent Zundel: the resource integrity is literally adding that term to the vocabulary (rather than integrity of the vocabulary).

@iherman
Copy link
Member

iherman commented Sep 4, 2023

Oops. Coming back from my short holidays, I took the various new issues/comments in a fairly random order... I have run into the same issue while answering another issue, see w3c/vc-data-model#1265 (comment).

TL;DR: I believe the vocabulary misses two properties:

  • digestSRI's domain is any Resource (but not a BNode), range is, at first approximation, xsd:string (ideally, a datatype that describes exactly what the value looks like).
  • mediaType's domain is any Resource (but not a BNode), range is, at first approximation, xsd:string (ideally, a datatype that describes exactly the media type string).

These two properties are not only missing from the vocabulary, but also missing from the context!

Note that, for the mediaType, an alternative would be to use the term encodingFormat instead, referring to http://schema.org/encodingFormat. Do not reinvent the wheel, and all that... That would mean just add an entry to the context file, and this property is oblivious to the vocabulary.

Do I understand the question right, @mprorock @OR13 ?

@OR13
Copy link
Contributor

OR13 commented Sep 11, 2023

Yep, the need to be added to both, I would do best effort on domain and range, but he key part is that they appear in the context, or they won't benefit the core data models semantics value proposition.

@brentzundel brentzundel transferred this issue from w3c/vc-data-model Sep 14, 2023
@msporny msporny closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for pr This issue is ready to be resolved via a pull request
Projects
None yet
Development

No branches or pull requests

5 participants