-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe how JSON-LD framing is used with Selective Disclosure #107
Comments
Why? I think referencing the framing document is sufficient and providing examples goes a bit too far in terms of the scope of the specification |
@Sakurann See this thread: w3c/vc-data-model#831 (comment) |
In the context of the core data model, framing allows for a representation of a view on a verifiable credential, for example:
If JSON-LD is assumed in the base media type, then APIs that operate on JSON-LD are also assumed, and yet, we don't provide any meaningful guidance on this front. |
The issue was discussed in a meeting on 2023-04-11
View the transcript1.10. Add examples of JSON-LD Framing (issue vc-data-model#1029)See github issue vc-data-model#1029. Kristina Yasuda: "Add examples of JSON-LD Framing". Orie Steele: when the JSON-LD context is applied, and then removed all that remains is n-quads - and the n-quads is the canonical representation. Manu Sporny: agree with orie's statement around moving this to a better place - sure let's talk about framing, but in the right place.
Michael Prorock: I agree with the right place for this thing not being in core data model, and if you want to go down the JSON-LD thing, there's a lot of documentation around JSON-LD and RDF and those sorts of things. It might be beneficial to add good examples to an implementation guide -- someone has to do that work? Let's close this in favor, it belongs elsewhere..
Kristina Yasuda: would you be ok with closing if addressed elsewhere?. Orie Steele: thinks we will have to address this in BBS. |
1 similar comment
The issue was discussed in a meeting on 2023-04-11
View the transcript1.10. Add examples of JSON-LD Framing (issue vc-data-model#1029)See github issue vc-data-model#1029. Kristina Yasuda: "Add examples of JSON-LD Framing". Orie Steele: when the JSON-LD context is applied, and then removed all that remains is n-quads - and the n-quads is the canonical representation. Manu Sporny: agree with orie's statement around moving this to a better place - sure let's talk about framing, but in the right place.
Michael Prorock: I agree with the right place for this thing not being in core data model, and if you want to go down the JSON-LD thing, there's a lot of documentation around JSON-LD and RDF and those sorts of things. It might be beneficial to add good examples to an implementation guide -- someone has to do that work? Let's close this in favor, it belongs elsewhere..
Kristina Yasuda: would you be ok with closing if addressed elsewhere?. Orie Steele: thinks we will have to address this in BBS. |
The is related to the discussions regarding mappings, since |
Frames and JSON Pointers should be commented on, people use them for selective disclosure, but that's not defined well anywhere. |
See this request to use framing with selective disclosure of application n quads: https://lists.w3.org/Archives/Public/public-credentials/2023Jun/0164.html |
There was a request to change the title on todays call, I will attempt to revise the title and description based on recent announcements in the credentials community group. |
The issue was discussed in a meeting on 2023-06-28
View the transcript2.11. Describe how JSON-LD framing is used with Selective Disclosure (issue vc-data-model#1029)See github issue vc-data-model#1029. Brent Zundel: #107 - Orie? Orie Steele: Get mailing list comments into the minutes: https://lists.w3.org/Archives/Public/public-credentials/2023Jun/0165.html. Request for support for data integrity selective disclosure that heavily uses JSON-LD framing. Manu Sporny: this isn't core data model work, and not needed in the core spec. If we need to we can point people to the W3C JSON-LD framing. Brent Zundel: what is the disposition of this issue? Manu Sporny: can move it to data integrity.
Ivan Herman: probably post-CR. Manu Sporny: no. the algorithms Orie is talking about need to be in pre-CR. Orie Steele: WG may adopt EDDCSA-SD so it should be in the core data model repo? Brent Zundel: leave as pre-PR.
|
Possible text, you don't need to use JSON-LD frame to support selective disclosure, you can simply process and disclose claims as is done in SD-JWT? |
Yes, please assign both of us to it so we can drive it forward as we have time. I think we should move this to the data integrity work so when we add some text on how to use framing to do selective disclosure with, e.g., BBS, we will address it.
I'll presume you meant this jokingly since that would be very silly to only say that about framing. In fact, we could simplify selective disclosure further by just using paper and a black marker! :) I think what you're driving at here is what you mentioned previously on a call: that it would be good to help people understand the advantages of the framing approach over others. That's a good idea and we should, for example, mention that if you have a JSON-LD framing primitive in hand already, then you can use it when doing selective disclosure to leak less relational information without having to remodel your data. This is one privacy advantage over other approaches. This is because framing works with the atomic statements at the core of the VCDM. |
@dlongley yes : ) Maybe this doesn't belong in the core data model, if its specific to how data integrity makes use of framing for selective disclosure. I could see it going in "suites", like BBS... But I think it would be best addressed in data integrity and referenced from the core data model. I leave it to you and @msporny to address, let me know if you want a review. |
Yes, agree.
Yes, agree that it should probably go in Data Integrity, don't know if VCDM needs to talk about it at all since it's mostly an implementation detail of specific cryptographic suites.
Ok, will make an attempt at some text in the next few weeks. @brentzundel @Sakurann -- can we transfer this issue to the VC Data Integrity specification, please? |
Marking as after CR since this is just going to be explanatory text on how JSON-LD Framing is used, with references to the normative text in the JSON-LD Framing standard. |
Not sure I agree with comment that is is after CR, depends on outcome of w3c/vc-data-model#1227 |
Folks (@OR13, @msporny, @dlongley) selective disclosure primitives used in VC-DI-ECDSA and VC-DI-BBS haven't used JSON-LD framing for quite some time. They use a JSON pointer based algorithm independent of JSON-LD. Can we close this now. |
Yes, +1 to close. |
Agreed, no need to document something we don't use. |
We should provide some examples of how JSON-LD Frame operation works, relative to the examples in the spec.
Especially in the context of BBS / selective disclosure... see https://w3c-ccg.github.io/ldp-bbs2020/
Even without BBS, I think some examples of how Framing is supposed to work, would be helpful.
Update:
https://lists.w3.org/Archives/Public/public-credentials/2023Jun/0164.html
https://github.com/digitalbazaar/ecdsa-sd-2023-cryptosuite/blob/62c76663f81cb6f836efd5f28109ae3ede113e5d/lib/disclose.js#L141
The text was updated successfully, but these errors were encountered: