Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Add tests for TouchEvent and Touch constructors #27

Closed
RByers opened this issue Aug 6, 2015 · 7 comments
Closed

Add tests for TouchEvent and Touch constructors #27

RByers opened this issue Aug 6, 2015 · 7 comments
Assignees
Labels

Comments

@RByers
Copy link
Contributor

RByers commented Aug 6, 2015

With constructors in the spec (#10) we should add some test cases to web-platform-tests for them.

@RByers RByers self-assigned this Oct 26, 2015
@RByers
Copy link
Contributor Author

RByers commented Oct 26, 2015

We'll do this as part of implementing the constructors in blink. It should be easy - just create a new test similar to create-touch-touchlist but that uses the constructor syntax instead.

@RByers
Copy link
Contributor Author

RByers commented Nov 3, 2015

Note (for public-touchevents) that a pull request is under review here. I'm not entirely sure of the process here, so please weigh in if you have advice.

@AFBarstow
Copy link
Contributor

@RByers you mean how to get a w-p-t PR reviewed (and merged)?

The formal-ish documentation appears to be in w-p-t's review-process document.

In practice, it can help to ask for a review (especially if the commit is relatively small) in W3C's #testing IRC channel.

(I think only a few people can merge w-p-t PRs.)

@RByers
Copy link
Contributor Author

RByers commented Nov 4, 2015

@AFBarstow thanks!

@chong-z
Copy link
Contributor

chong-z commented Nov 4, 2015

Thanks! I will land the blink code first so we can test it on Chrome build

@chong-z
Copy link
Contributor

chong-z commented Mar 8, 2016

Fixed in web-platform-tests/wpt#2299

@RByers
Copy link
Contributor Author

RByers commented Mar 8, 2016

Thank you!

@RByers RByers closed this as completed Mar 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants