Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Presentation API Test results #107

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Conversation

louaybassbouss
Copy link
Contributor

This PR updates the test results of Presentation API. Three Browsers are considered:

  • CA61: Chrome Canary for Android Version 61.x.x
  • CD59: Chrome for Desktop Version 59.x.x
  • FA56: Firefox for Android Version 56.x.x

@louaybassbouss
Copy link
Contributor Author

@tidoust FYI

@tidoust
Copy link
Member

tidoust commented Jul 17, 2017

Controlling side looks good.

Could you clarify what the columns represent for the receiver results?

I would basically have expected to see:

  • CD59: Chrome for Desktop Version 59.x.x acting as 1-UA receiver to pilot a Chromecast device
  • FA56: Firefox for Android Version 56.x.x acting as 1-UA receiver to pilot a Chromecast device

... and my understanding is that CA61 would not appear as a receiver, because Chrome Canary for Android Version 61.x.x does not come with a 1-UA receiver, and Chromecast devices are not proper receivers either (since they use a proprietary Cast SDK).

Instead, I see CD53 which seems good (not the same version as the tested controller, but why not) and CC47 and CC49 which, for me, do not mean much since Chromecast devices do not implement the receiver side of the Presentation API. Or did I miss an update?

@markafoltz
Copy link

To clarify, Chromecast devices can act as presentation screens in 1-UA mode (they do not yet implement presentation receiver).

@louaybassbouss Can you answer Francois' other questions?

@markafoltz
Copy link

Ping @louaybassbouss

@anssiko
Copy link
Member

anssiko commented Aug 29, 2017

Bumping this issue for @louaybassbouss feedback: @tidoust had a question #107 (comment) looking for an answer.

Ping @Honry to gauge if he'd be available to help. Also looping in @tomoyukilabs.

@Honry
Copy link
Contributor

Honry commented Aug 30, 2017

@anssiko, @tidoust's concern on why there's no update for receiving side, sorry, I would like to help but I have no Chromecast in hand.

@tomoyukilabs
Copy link
Contributor

tomoyukilabs commented Aug 30, 2017

If I understand correctly, it seems that the results of controlling UA tests placed in presentation-api/controlling-ua are present and up-to-date, but the results of receiving UA tests in presentation-api/receiving-ua have not been updated yet.

Can I help you to update the receiver test results?

@Honry
Copy link
Contributor

Honry commented Sep 1, 2017

@anssiko, I just got one Chromecast device and can help update the receiver test results at any time.
@tomoyukilabs, please kindly let me know if you are doing the same things. :)

@Honry
Copy link
Contributor

Honry commented Sep 6, 2017

I just update the Receiving UA test results at #111 with CD59 and FA56.

@tidoust
Copy link
Member

tidoust commented Sep 6, 2017

Thanks @Honry! PR #111 looked good to me, so I went ahead and merged it.

Now, this PR still contains test result updates for the controller side. @louaybassbouss, any chance that you could drop files that touch on the receiving side from this PR so that I can merge the reminder?

@tidoust
Copy link
Member

tidoust commented Sep 14, 2017

@Honry or @tomoyukilabs, any change that one of you could help with updating the test results for the controller side?

@tomoyukilabs
Copy link
Contributor

@tidoust First, could you merge this PR for now? Then I would like to submit another PR to update the results of both controller and receiver.

I suppose that wptserver's stash, which is used for communication between controller and receiver, could not often work properly on w3c-test.org, and that would affect the test results. For this reason, I would like to run the tests on my local environment (./wpt serve) and update the test report.

@Honry
Copy link
Contributor

Honry commented Sep 15, 2017

I am considering if we should deliver an up-to-date test results with latest Browsers, Chrome is now M63 and Firefox Nightly is 57.

@tidoust tidoust merged commit 929818c into w3c:gh-pages Sep 15, 2017
@markafoltz
Copy link

My understanding is that some of the current failures are because of problems with w3c-test.org? Is the current implementation report valid or does it need to be re-done with a local server?

@Honry
Copy link
Contributor

Honry commented Sep 20, 2017

@tomoyukilabs is testing on a local server, and then we will see the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants