Rework the 'Connect to Sensor' abstract operation #300
Conversation
| 1. Return true. | ||
| 1. If the device has multiple [=device sensors=] which can provide [=sensor readings|readings=] | ||
| for |type|, then | ||
| 1. If |type| has an associated [=default sensor=], then |
There was a problem hiding this comment.
If platform does not have concept of default sensor, false would be returned, is that expected?
There was a problem hiding this comment.
but that's not a platform concept, default sensor is defined in an extension API, e.g. here https://www.w3.org/TR/accelerometer/#model, so if a device has multiple accelerometers, the UA will assume one of them to be the default.
There was a problem hiding this comment.
thanks, additional text addresses my concern about vague definition of default sensor.
There was a problem hiding this comment.
Outside this change in Sensor.start(), where you invoke this connect to sensor abstract operation, you should change:
let connected be the result of invoking connect to sensor.
To
let connected be the result of invoking connect to sensor with sensor_instance as argument.
Might be a separate patch, or could be rolled into this one since related.
pozdnyakov
force-pushed
the
dropIdentifyingParamaters
branch
from
eee447e
to
61be6d7
Compare
| 1. Return true. | ||
| 1. If the device has multiple [=device sensors=] which can provide [=sensor readings|readings=] | ||
| for |type|, then | ||
| 1. If |type| has an associated [=default sensor=], then |
There was a problem hiding this comment.
Outside this change in Sensor.start(), where you invoke this connect to sensor abstract operation, you should change:
let connected be the result of invoking connect to sensor.
To
let connected be the result of invoking connect to sensor with sensor_instance as argument.
Might be a separate patch, or could be rolled into this one since related.
This patch: - Reworks the 'Connect to Sensor' abstract operation, so that it properly handles multiple device sensors - Drops 'identifying parameters' as those are unnecessary unless the Sensor Discovery functionality is in place. We might put them back when fixing w3c#7.
pozdnyakov
force-pushed
the
dropIdentifyingParamaters
branch
from
61be6d7
to
7600ff4
Compare
|
@anssiko thanks for the catch! it is fixed now. |
This patch:
it properly handles multiple device sensors
unless the Sensor Discovery functionality is in place.
We might put them back when fixing Sensor discovery #7.
Preview | Diff