Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire selectionchange on input/textarea elements #141

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jun 15, 2021

Closes (partially) #53, since this only covers selectionchange without selectstart because of no implementation.

Closes #75.

This follows the suggestion from @smaug---- - to bubble up from text controls to document, since it allows to easily detect which text control fired it.

(document.activeElement can be used in some cases to detect the source, but it's not always useful since it can be fired without focusing, e.g. through .setSelectionRange().)

The following tasks have been completed:

  • Modified Web platform tests (link to pull request) -

Implementation commitment:


Preview | Diff

@saschanaz saschanaz requested a review from rniwa June 15, 2021 23:00
@saschanaz
Copy link
Member Author

saschanaz commented Jun 15, 2021

@rniwa Sorry to ping you repeatedly for GitHub Action issue. The GitHub action changed its name to "Validate and Publish" from "Build and Validate" by #138, so it needs to be changed in the Settings page too.

@saschanaz saschanaz mentioned this pull request Jul 13, 2021
@tkent-google
Copy link

Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) @tkent-google?

I support this change.

@marcoscaceres
Copy link
Member

@saschanaz, I gave you admin rights on the repo also. Hope that helps!

Copy link
Contributor

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@foolip
Copy link
Member

foolip commented May 18, 2022

Looks like https://bugs.webkit.org/show_bug.cgi?id=234348 is the WebKit bug for this.

@tkent-google did you file a Chromium bug?

@tkent-google
Copy link

@tkent-google did you file a Chromium bug?

I have just filed https://bugs.chromium.org/p/chromium/issues/detail?id=1327098 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit onselectionchange to Document until known to be needed elsewhere
5 participants