Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple versions of card art icon? (E.g. to support dark mode) #1

Closed
danyao opened this issue Jul 24, 2020 · 6 comments
Closed

Multiple versions of card art icon? (E.g. to support dark mode) #1

danyao opened this issue Jul 24, 2020 · 6 comments
Milestone

Comments

@danyao
Copy link
Contributor

danyao commented Jul 24, 2020

The code snippet in the explainer suggests that the caller can provide multiple icons. Wouldn't one icon be sufficient?

const publicKeyCredentialCreationOptions = {
  paymentInstrument: {
    name: 'Mastercard****4444',
    icons: [{
  	  'src': 'icon.png',
  	  'sizes': '48x48',
  	  'type': 'image/png',
    }],
  },
...
danyao added a commit that referenced this issue Jul 27, 2020
Add API sketch and clarify data structures.
@adrianhopebailie
Copy link
Collaborator

Maybe the right thing is to be able to provide multiple instruments with a single icon per instrument?

Is the expectation that the provided icon will be high-res and the browser will scale it appropriately?

What about dark-mode 😄

@danyao
Copy link
Contributor Author

danyao commented Jul 31, 2020

Maybe the right thing is to be able to provide multiple instruments with a single icon per instrument?

Filed #13 to track the instrument cardinality question. 😎

Is the expectation that the provided icon will be high-res and the browser will scale it appropriately?

Yeah. Browser will download and save these icons at credential enrollment time. So we'll probably only save the scaled down version.

What about dark-mode 😄

Good point. In that case, we should probably also specify the purpose of the icon.

@danyao danyao added this to the TAG Review milestone Jul 31, 2020
@marcoscaceres
Copy link
Member

probably want to use https://github.com/w3c/image-resource

@ianbjacobs
Copy link
Collaborator

ianbjacobs commented Jul 26, 2021

I think this issue may still be relevant at authentication time (even if icon info is not set at enrollment). For example, how would dark mode be handled?

@stephenmcgruer stephenmcgruer changed the title One icon per credential Multiple versions of cart art icon? (E.g. to support dark mode) Sep 3, 2021
@stephenmcgruer stephenmcgruer changed the title Multiple versions of cart art icon? (E.g. to support dark mode) Multiple versions of card art icon? (E.g. to support dark mode) Nov 12, 2021
@JeanDim
Copy link

JeanDim commented Mar 3, 2022

On the 3DS 2.3.0 protocol, dark mode has been take into account for the payment system and issuer logo to be display.
If SPC is triggered during a frictionless 3DS flow (AReq/ARes level) the ACS MAY (optional) populate the spcTransData object with issuer (issuerImageSpc) and payment system (psImageSpc) dark mode logo by referencing URLs or Data URl with b64 encoded format.

For the 3DS challenge flow (CReq/CRes level ) for APP-based (could be JS SDK), dark mode is also possible (optional field) for issuer and payment system logo. For browser-based, the ACS would defined directly (outside 3DS protocol) the logo to use I guess

@ianbjacobs
Copy link
Collaborator

After discussion with the chairs and editors we have concluded that the primary use case here is to support "dark mode." The dark mode use case can be addressed by using client-side JavaScript, and thus we are closing this issue until we hear additional use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants