-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify {transfer,encodedBody,decodedBody}size #41
Conversation
- spell out cache vs network fetch behavior - notes for non-2xx responses closes #40
<ul> | ||
<li>If the resource is retrieved from <a href="http://www.w3.org/TR/html5/browsers.html#relevant-application-cache" title='relevant application cache'>relevant application caches</a> or from local resources, it must return zero.</li> | ||
<li>If there are HTTP redirects or <a href="http://www.w3.org/TR/html5/infrastructure.html#concept-http-equivalent-codes" title='HTTP response codes equivalence'>equivalent</a> when navigating and if all the redirects or equivalent are from the same <a href="https://tools.ietf.org/html/rfc6454#section-4">origin</a> [[!RFC6454]], this attribute SHOULD include the HTTP overhead of incurred redirects.</li> | ||
<li>If the last non-redirected <a href="http://www.w3.org/TR/html5/infrastructure.html#fetch">fetch</a> of the resource is not the same origin as the <a>current document</a>, <a href="#widl-PerformanceResourceTiming-transferSize">transferSize</a> MUST return zero unless the <a href="#timing-allow-check">timing allow check</a> algorithm passes.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we distinguish "not allowed" from 0? I can imagine cases where apps would need to know which is which. (and even more cases where apps would consider one as the other)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? Note that we'd make it inconsistent with timing attributes which report 0..
@yoavweiss @valenting updated, PTAL. Does this resolve issues raised in #40? |
It does for me. Thanks! |
LGTM. Did you remove the reference to multiple redirect counting (and the fact that they are counted only if all pass Timing-allowed) on purpose? I thought we settled on keeping it (and possibly improving it in the future to account for partially allowed redirect chains) |
@yoavweiss those checks are still there, just under an |
clarify {transfer,encodedBody,decodedBody}size
closes #40