Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose PushSubscriptionOptions value on PushSubscription #184

Closed
martinthomson opened this issue Jan 28, 2016 · 1 comment
Closed

Expose PushSubscriptionOptions value on PushSubscription #184

martinthomson opened this issue Jan 28, 2016 · 1 comment

Comments

@martinthomson
Copy link
Member

We should expose the options that were set in a call to subscribe().

Two concerns:

  • we probably don't want to serialize these.
  • we need to make it clear that unsupported attributes will not be saved (setting options to { chocolate: false } will not result in a value being saved for you.

As mentioned in #182 and #183.
@martinthomson martinthomson mentioned this issue Mar 4, 2016
Merged
@martinthomson
Copy link
Member Author

Closed by #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinthomson