Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you change the value of PushSubscriptionOptions #183

Closed
martinthomson opened this issue Jan 28, 2016 · 2 comments
Closed

Can you change the value of PushSubscriptionOptions #183

martinthomson opened this issue Jan 28, 2016 · 2 comments
Assignees

Comments

@martinthomson
Copy link
Member

When calling subscribe(), what happens if there is an active subscription with a different set of values for its PushSubscriptionOptions? We can reject the call with InvalidAccessError, NoModificationAllowedError, or even InvalidStateError. Or we can create a new subscription with the new options.

I think that the current view is that rejection is cleanest (and leads to fewer surprises). However, in the we will need to separately expose the current state of the options in the interests of transparency.

This came up in #182.

@mvano
Copy link
Contributor

mvano commented Feb 8, 2016

I slightly prefer InvalidStateError, as NoModificationAllowedError ties us closer to the one subscription per registration model.

There is a very small chance that this would break existing functionality. But really currently it's only the userVisibleOnly boolean so maybe it's best that we change this behavior before the really interesting stuff is added to PushSubscriptionOptions.

@martinthomson
Copy link
Member Author

This was addressed in #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants