You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling subscribe(), what happens if there is an active subscription with a different set of values for its PushSubscriptionOptions? We can reject the call with InvalidAccessError, NoModificationAllowedError, or even InvalidStateError. Or we can create a new subscription with the new options.
I think that the current view is that rejection is cleanest (and leads to fewer surprises). However, in the we will need to separately expose the current state of the options in the interests of transparency.
I slightly prefer InvalidStateError, as NoModificationAllowedError ties us closer to the one subscription per registration model.
There is a very small chance that this would break existing functionality. But really currently it's only the userVisibleOnly boolean so maybe it's best that we change this behavior before the really interesting stuff is added to PushSubscriptionOptions.
When calling
subscribe()
, what happens if there is an active subscription with a different set of values for itsPushSubscriptionOptions
? We can reject the call withInvalidAccessError
,NoModificationAllowedError
, or evenInvalidStateError
. Or we can create a new subscription with the new options.I think that the current view is that rejection is cleanest (and leads to fewer surprises). However, in the we will need to separately expose the current state of the options in the interests of transparency.
This came up in #182.
The text was updated successfully, but these errors were encountered: