Add persistentDeviceId to PointerEvent #495

sahirv · 2024-01-11T21:51:49Z

This change proposes the introduction of a new attribute to the PointerEvent interface - persistentDeviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

This pull request is expected to make the 4th iteration of the PointerEvent specification.

Preview | Diff

This change proposes the introduction of a new attribute to the PointerEvent interface - deviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

patrickhlauke · 2024-01-17T16:40:05Z

Worth adding, for context, #353

sahirv · 2024-01-17T17:01:54Z

Happy to take any comments on the changes. The idea is based on that of pointer id; -1 is reserved for invalid ids. In Chromium, 1 is reserved for the mouse pointer (0 is unused); but I left the wording to be similar to the pointerId definition. As long as the deviceId is unique for each device, web devs should not have a problem.

index.html

sahirv · 2024-03-05T22:27:43Z

Made changes to introduce deviceProperties rather than having deviceId on PointerEvent. Rough draft- feedback appreciated

index.html

This change replaces deviceId on the PointerEvent interface with a new interface, deviceProperties. DeviceProperties contains one member, uniqueId, which functionally behaves the same as the outgoing deviceId. Spec: w3c/pointerevents#495 This change also removes the setting of deviceId when creating a PointerCancel event, as there is no current application for device/unique id for a PointerCancel. Bug: 330760871 Change-Id: I0f1a9f7d5589f790d94f498a38bfdf55b6f51073

flackr · 2024-05-29T19:12:18Z

I'm okay with having a property directly on the PointerEvent, but would suggest some better differentiation from pointerId. E.g. maybe if we call it persistentId it will be obvious how/why it is different from the pointerId.

sahirv · 2024-05-30T16:53:16Z

maybe if we call it persistentId it will be obvious how/why it is different from the pointerId.

How does persistentDeviceId sound? By naming it this way we make it clear that:

This id will persist (for the session) differentiating it from pointerId.
This id is tied to the pointing device; not the event or sequence.

smaug---- · 2024-05-30T16:56:20Z

That is quite reasonable. It is long and perhaps weird enough that one wouldn't likely mix that with pointerId.

sahirv · 2024-05-30T18:11:15Z

@annevk @flackr @mustaqahmed Are you all good with this suggestion and the overall direction we're taking here?

… 0, a=testonly Automatic update from web-platform-tests Set Invalid DeviceProperties.uniqueId to 0 Replace -1 with 0 for the invalid uniqueId as per recent spec consensus. Spec: w3c/pointerevents#495 Bug: 330760871 Change-Id: I063515535ee0510c89942f16098c6211bafb480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463741 Reviewed-by: Robert Flack <[email protected]> Reviewed-by: Mustaq Ahmed <[email protected]> Commit-Queue: Sahir Vellani <[email protected]> Reviewed-by: Olga Gerchikov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1290720} -- wpt-commits: a2bf027ec76e7f183c4f7e3fdcd62d5a0e818598 wpt-pr: 45765

sahirv · 2024-06-10T17:05:14Z

@smaug---- @flackr @mustaqahmed I have updated this PR to introduce persistentDeviceId. Please take a look and leave your feedback. Thank you :)

sahirv · 2024-06-17T19:48:19Z

Gentle ping :)

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <[email protected]> Reviewed-by: Olga Gerchikov <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1318886}

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <[email protected]> Reviewed-by: Olga Gerchikov <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <sahir.vellanimicrosoft.com> Reviewed-by: Olga Gerchikov <gerchikomicrosoft.com> Reviewed-by: Robert Flack <flackrchromium.org> Cr-Commit-Position: refs/heads/main{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888 UltraBlame original commit: 84225becd9d58cb4946fefdbbd42aeda5dc9445c

…PointerEvent.persistentDeviceId, a=testonly Automatic update from web-platform-tests Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <[email protected]> Reviewed-by: Olga Gerchikov <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1318886} -- wpt-commits: b29c0837b336a17d4aca09b9afbb82ac30748385 wpt-pr: 46888

patrickhlauke · 2024-07-04T13:47:34Z

repointed this PR to the new next branch

smaug---- · 2024-07-17T15:44:06Z

Looks like the tests rely on window.internals. What is that? And why are the non-manual tests passing in all the browsers even if the API isn't implemented. Could the tests be fixed?

Bring back a unique id on the base pointer event and remove deviceProperties. Rather than deviceId, this will be called persistentDeviceId. Spec: w3c/pointerevents#495 Change-Id: Ia284adc60bc4030b69dbec89d0e37117fecf3f83 Bug: 330760871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643255 Commit-Queue: Sahir Vellani <[email protected]> Reviewed-by: Olga Gerchikov <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1318886}

sahirv · 2024-07-18T17:12:57Z

Thanks for bringing the tests up! I'll look into it and report back here.

sahirv · 2024-07-29T16:49:23Z

The tests have been fixed.

patrickhlauke · 2024-08-14T15:02:05Z

Merged into the next version of the spec, as discussed here https://www.w3.org/2024/07/31-pointerevents-minutes.html#t03

Add deviceId to PointerEvent spec

53aa55e

This change proposes the introduction of a new attribute to the PointerEvent interface - deviceId. See: https://github.com/WICG/pointer-event-extensions/blob/main/pointer-event-device-id-explainer.md

patrickhlauke added the future label Jan 17, 2024

flackr reviewed Jan 18, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

ogerchikov reviewed Jan 18, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Specify value of 1 for mouse events

abe761f

flackr mentioned this pull request Jan 23, 2024

Multi-pen support and persistent pointerId #353

Closed

Switch to deviceProperties

55a1acc

sahirv changed the title ~~Add deviceId to PointerEvent spec~~ Add deviceProperties.uniqueId to PointerEvent spec Mar 5, 2024

sahirv added 2 commits March 5, 2024 14:34

Fix example numbering

bcd5db0

Add some more details to uniqueId decription

06be8e0

ogerchikov reviewed Mar 5, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

ogerchikov reviewed Mar 5, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Add constructor

fe6a97d

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

smaug---- reviewed Mar 11, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Address feedback

dd4ea5a

sahirv requested a review from flackr March 11, 2024 18:00

flackr reviewed Mar 20, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

Address feedback, add init dict

453da9f

flackr reviewed Mar 26, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

sahirv added 2 commits March 26, 2024 13:44

Fix example

b2d7e83

Fix default value in dict

eefea6e

chromium-wpt-export-bot mentioned this pull request Mar 28, 2024

Introduce PointerEvent.deviceProperties web-platform-tests/wpt#45420

Merged

Switch to persistentDeviceId

8853ccf

sahirv changed the title ~~Add deviceProperties.uniqueId to PointerEvent spec~~ Add persistentDeviceId to PointerEvent Jun 10, 2024

flackr approved these changes Jun 19, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Jun 24, 2024

Swap PointerEvent.deviceProperties with PointerEvent.persistentDeviceId web-platform-tests/wpt#46888

Merged

patrickhlauke changed the base branch from gh-pages to next July 4, 2024 13:47

Elchi3 mentioned this pull request Jul 25, 2024

Add PointerEvent.deviceProperties openwebdocs/mdn-bcd-collector#1692

Merged

patrickhlauke changed the base branch from next to gh-pages August 14, 2024 12:55

patrickhlauke merged commit 3ec245e into w3c:gh-pages Aug 14, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add persistentDeviceId to PointerEvent #495

Add persistentDeviceId to PointerEvent #495

sahirv commented Jan 11, 2024 •

edited by pr-preview bot

Loading

patrickhlauke commented Jan 17, 2024

sahirv commented Jan 17, 2024

sahirv commented Mar 5, 2024

flackr commented May 29, 2024

sahirv commented May 30, 2024

smaug---- commented May 30, 2024

sahirv commented May 30, 2024

sahirv commented Jun 10, 2024

sahirv commented Jun 17, 2024

patrickhlauke commented Jul 4, 2024

smaug---- commented Jul 17, 2024 •

edited

Loading

sahirv commented Jul 18, 2024

sahirv commented Jul 29, 2024

patrickhlauke commented Aug 14, 2024

Add persistentDeviceId to PointerEvent #495

Add persistentDeviceId to PointerEvent #495

Conversation

sahirv commented Jan 11, 2024 • edited by pr-preview bot Loading

patrickhlauke commented Jan 17, 2024

sahirv commented Jan 17, 2024

sahirv commented Mar 5, 2024

flackr commented May 29, 2024

sahirv commented May 30, 2024

smaug---- commented May 30, 2024

sahirv commented May 30, 2024

sahirv commented Jun 10, 2024

sahirv commented Jun 17, 2024

patrickhlauke commented Jul 4, 2024

smaug---- commented Jul 17, 2024 • edited Loading

sahirv commented Jul 18, 2024

sahirv commented Jul 29, 2024

patrickhlauke commented Aug 14, 2024

sahirv commented Jan 11, 2024 •

edited by pr-preview bot

Loading

smaug---- commented Jul 17, 2024 •

edited

Loading