Add optional description to PaymentShippingOption #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
PaymentShippingOption.description
branch
from
ed426ba to
19a0e64
Compare
rsolomakhin
approved these changes
May 22, 2020
|
@rsolomakhin, is this something you will plan on supporting in Chrome (or already support)? |
|
Blocking on implementer interest... I don't mind adding this to Firefox if it will be helpful to pass along to a payment handler. |
|
@sahel-sh - do we still have interest from payment handlers for this field? |
|
Sorry I missed this earlier. |
|
No more shipping stuff thanks to #955 ... can now be done with private data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #902
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
Preview | Diff