Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to issue #51. #85

Closed
wants to merge 3 commits into from
Closed

Conversation

msporny
Copy link
Member

@msporny msporny commented Mar 16, 2016

Add a reference to issue #51.

@adrianhopebailie
Copy link
Collaborator

@msporny Can you reword this to be a lot simpler and leave the deeper explanation for users to read in the issue itself? I would also suggest placing this issue marker alongside those for #15 and #16 which also relate to the shape and behavour of the API.

Suggestion:

<div class="issue" data-number="51" title="How should the API interact with the website
when exchanging data such as shipping address and options"> There is an open issue about 
whether the current pattern of using events for exchange of data between the user agent and
the website is the best design and an alternative has been proposed in this issue thread.</div>

@msporny
Copy link
Member Author

msporny commented Mar 29, 2016

@adrianhopebailie wrote:

Can you reword this to be a lot simpler

Done with minor changes to your language. The issue has been moved to where you wanted it to go.

@adrianba
Copy link
Contributor

adrianba commented Apr 1, 2016

Merged as 7ef4a69

@adrianba adrianba closed this Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants