editorial: add example of .toJSON()+fetch POST #583
Conversation
index.html
Outdated
| try { | ||
| const httpResponse = await fetch("/process-payment", { | ||
| method: "POST", | ||
| headers: new Headers({ "Content-Type": "application/json" }), |
There was a problem hiding this comment.
new Headers is not necessary; you can pass the object literal directly.
| }); | ||
| result = httpResponse.ok ? "success" : "fail"; | ||
| } catch (err) { | ||
| console.error(err); |
There was a problem hiding this comment.
Should this set result = "fail"?
There was a problem hiding this comment.
Probably... but wanted to show the "unknown" state somehow.
There was a problem hiding this comment.
Maybe do a quick parse of response.json() ? I dunno. I have a hard time understanding "unknown" in real-world systems...
There was a problem hiding this comment.
yeah, me too :( Ok, will just add a comment about "unknown" that it's an option that people can use if they need it... however, we should try to come up with something real or we should mark it "at risk".
Chrome currently does nothing with "unknown" (behaves the same as "success", in that no error is shown to the user). I don't know if we (Firefox) will do anything with "unknown" at this point.
There was a problem hiding this comment.
Removed mention of "unknown", as I have a feeling it's it won't survive CR.
Preview | Diff