Refactor the supportedMethods and payment specific data #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the first argument to the PaymentRequest constructor to combine the supportedMethods and payment method specific data. By making this change it is possible to share an instance of data amongst multiple payment methods that wasn't possible before.
|
This is an improvement over what is in the spec now. +1 to merge, even though I disagree w/ generic data containers like "data". I still think the first argument should be a single PaymentRequest message ... something like what's defined in the Core Messages proposal. All that said, I'd rather have this than what we have in the spec now, so +1 to merge. |
adrianba
added a commit
to adrianba/browser-payment-api
that referenced
this pull request
Apr 28, 2016
Fixes w3c#48. PR w3c#162 refactored the supportedMethods and payment specific data fields. Issue w3c#3 discusses supporting multiple currencies and issue w3c#4 discusses price per payment method and we should consider specific proposals for those issues. PR w3c#162 replaces the `sequence<DOMString>` with `sequence<PaymentMethodData>` so we now use objects.
Closed
adrianba
added a commit
that referenced
this pull request
Apr 28, 2016
Fixes #48. PR #162 refactored the supportedMethods and payment specific data fields. Issue #3 discusses supporting multiple currencies and issue #4 discusses price per payment method and we should consider specific proposals for those issues. PR #162 replaces the `sequence<DOMString>` with `sequence<PaymentMethodData>` so we now use objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the first argument to the PaymentRequest constructor
to combine the supportedMethods and payment method specific data. By
making this change it is possible to share an instance of data amongst
multiple payment methods that wasn't possible before.