Define generalized PMI validator #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
validate
branch
2 times, most recently
from
2b84075 to
97fcb88
Compare
rsolomakhin
approved these changes
Aug 14, 2017
domenic
approved these changes
Aug 14, 2017
index.html
Outdated
| </p> | ||
| <ol> | ||
| <li>Let <var>url</var> be the result of running the <a>basic URL | ||
| parser</a> with <var>pmi</var>. |
There was a problem hiding this comment.
basic URL parser link isn't working in https://rawgit.com/w3c/payment-method-id/97fcb88628ab8a34c25d89b1caf435abf12d1e47/index.html
index.html
Outdated
| </h3> | ||
| <p> | ||
| The steps to <dfn>validate a payment method identifier</dfn> with a | ||
| <var>pmi</var> string are given by the following algorithm. It |
There was a problem hiding this comment.
Nit: both here and in other algorithms you seem to put the type after the variable name, but that's pretty unusual in web specs. "string pmi" and "URL url" would be more expected.
There was a problem hiding this comment.
Makes sense, will fix here and then update globally. The other ones are badly written also, so will clean them up to match.
marcoscaceres
force-pushed
the
validate
branch
from
97fcb88 to
ff09155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for w3c/payment-request#464
Preview | Diff