Remove PaymentInstruments API #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaymentInstruments is the Web API that backs non-JIT install of payment apps. It was designed with the assumption that the browser would store the actual payment instrument details, which has not turned out to be true, and has some privacy leaks. This patch removes the ability to register a payment handler via paymentManager.instruments API. Only just-in-time installation is supported from now on. Chrome tracking bug: https://crbug.com/1327265 Chrome status: https://chromestatus.com/feature/5099285054488576 Overview of changes in the patch: * Remove PaymentInstruments interface. * Remove no longer used PaymentInstrument and ImageOjbect dictionaries. * Mark PaymentManager exposed only on Window (not Worker) to match the Chrome implementation. * Add a definition for "payer" for symmetry with "payee" definition. * Soften the language around the purpose for the "canmakepayment" event to match Chrome implementation, where it is being used for hasEnrolledInstrument() instead of canMakePayment() and show(). * Add a promise to the "canmakepayment" example to reduce confusion stemmed from many examples that always unconditionally return "true". * Raise 2nd level sections to 1st level for clarity. * Remove the unused PaymentRequestEvent.fetchedImage internal slot.
|
@ianbjacobs & @stephenmcgruer: Please take a look. |
|
@rsolomakhin, one observation is that removing the PaymentInstruments interface should close a couple of other issues, namely #371 and maybe #381. |
ianbjacobs
reviewed
Jan 25, 2023
ianbjacobs
approved these changes
Jan 25, 2023
Good point! I've added these to the description of the pull request. |
stephenmcgruer
approved these changes
Jan 25, 2023
Co-authored-by: Stephen McGruer <[email protected]>
Co-authored-by: Stephen McGruer <[email protected]>
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentInstruments is the Web API that backs non-JIT install of payment apps. It was designed with the assumption that the browser would store the actual payment instrument details, which has not turned out to be true, and has some privacy leaks. This patch removes the ability to register a payment handler via
paymentManager.instrumentsAPI. Only just-in-time installation is supported from now on.Chrome tracking bug: https://crbug.com/1327265
Chrome status: https://chromestatus.com/feature/5099285054488576
Overview of changes in the patch:
Closes: #371
Closes: #381
Preview | Diff