-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource timing as base #36
Conversation
current document, this attribute MUST return a <a href="http://www.w3.org/TR/hr-time-2/#dom-domhighrestimestamp">DOMHighResTimeStamp</a> | ||
with a time value equal to zero.</p> | ||
</dd> | ||
<p>Only the <a>current document</a> resource gets included as the <em>only</em> <a>PerformanceNavigationTiming</a> object in the Performance Timeline of the relevant context.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent behind w3c/resource-timing#21 will break this.. Assuming we land that, there may be multiple PerformanceNavigationTiming records (e.g. one or more redirect requests plus final 200 OK req/resp).
That said, we probably don't have to deal with this in this pull and should revisit once we make above changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably indeed open a separate issue to match w3c/resource-timing#21
Also.. I guess the TAO stuff is implicit with this update, but it may be worth adding a note in security or privacy sections that some timestamps exposed by NT are subject to TAO, with pointer to RT? |
Also added TAO text |
I believe this is good to go. ok? |
@plehegar any chance you can also drop the commented out sections? (transferSize, etc). |
LGTM, thanks for tackling this one Philippe! Merging. I'm sure there is more to improve here but we can tackle that as followup and separate issues. |
@igrigorik any change you can take a first look at this attempt?
Note step 6 in the Processing Model. If it's a valid step, shouldn't we have a similar one for RT?