Add non-normative notes for attributes. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each attribute has a "note" explanation of when it is measured, with a link to the service-worker/HTML spec where it's being measured in practice. Also update the diagram to include service-worker handling. Closes #157.
yoavweiss
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
LGTM for prose. I want @nicjansma to look at the SVG diffs, as I know he was working on something similar as part of #128 and #131
Also, would be good to move to xref links instead of data-cite ones.
OK. I can also separate the SVG from this PR.
I think I will get to that separately, the spec is currently sprinkled with many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each attribute has a "note" explanation of when it is measured, with a
link to the service-worker/HTML spec where it's being measured in
practice.
Also update the diagram to include service-worker handling.
Closes #157.
Preview | Diff