Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new skip-ad media session action #203

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

beaufortfrancois
Copy link
Contributor

This PR adds a "skip ad" media session action that may be used by media notification and picture-in-picture window controls

Note that one already exists in Android Media Session: https://developer.android.com/reference/kotlin/android/support/v4/media/session/MediaSessionCompat#ACTION_SKIP_AD

We may want to add support for media session actions feature detection. WDYT?

@mounirlamouri

@jernoble
Copy link

This looks like a good solution for a common use case. 👍🏻

@beaufortfrancois beaufortfrancois changed the title Add new skip_ad media session action Add new skip-ad media session action Oct 24, 2018
@mounirlamouri mounirlamouri merged commit 3c09282 into w3c:master Oct 24, 2018
@beaufortfrancois beaufortfrancois deleted the skip-ad branch October 24, 2018 07:43
@beaufortfrancois beaufortfrancois mentioned this pull request Feb 4, 2019
@phistuck
Copy link

phistuck commented Feb 7, 2019

"Skip ad" seems highly specific to me. What if it is an introduction pre-roll that can be skipped?
Why not just "skip"?

@jernoble
Copy link

jernoble commented Feb 7, 2019

To pile on with @phistuck, one use case is Netflix’s “skip intro” button, which functions like a monotonically decreasing “seek forward X” button. Another is Netflix’s “next episode”, which is “next track” with custom text.

I wonder if we could cover more use cases by allowing sites to provide custom label text for these actions rather than providing specific actions for each use case.

YouTube could offer a “nexttrack” action with a { label: “skip ad”} payload, Netflix could offer a “seekforward” action with a { label: “skip intro” } payload, and a “nexttrack” with a { label: “next episode” } payload.

@OrenMe
Copy link

OrenMe commented Feb 7, 2019

Yes, agree as well with @jernoble and @phistuck and I mentioned some of this in
w3c/picture-in-picture#116 (comment)

There are also more cases for this like ad timer to skip and general ad timer till end of ad.
Also, some publishers insist on having “Advertisment” label when playing an ad, either it be regulatory requirement or just brand requirement.

What about ad clickthrough? Adding a “Learn more” button for ads.

Should we open a new issue for these? Are these concerns valid?

@jernoble
Copy link

jernoble commented Feb 7, 2019

@OrenMe I want to be careful not to go down the slippery slope to "full HTML replacement" here. And in fact, my point was to narrow the API rather than broaden it.

I think the "advertisement" label could be done with a forced subtitle track, if necessary. Ad clickthrough is harder, but I don't think we need to handle that use case explicitly in the Media Session spec. Sites that really, really want to could just add a "nexttrack" action with a { label: 'learn more' } payload. (I don't really like that idea, personally, but they could do it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants