Updating the spec to match current explainer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the size of the change, can you provide an HTML output I can look at? |
| Promise<void> activate(); | ||
| Promise<void> deactivate(); | ||
| partial interface Navigator { | ||
| readonly attribute MediaSession? mediaSession; |
There was a problem hiding this comment.
Why can MediaSession be null? If it's not null, shouldn't you use [SameObject]? see webidl
|
I think that change is fine. There are some things to fix here and there apart from my comments but better than a spec that no longer match the goal of our work. lgtm! :) |
| otherwise. On setting, the user agent must run the following steps: | ||
| <h2 id="processing-model">Processing model</h2> | ||
|
|
||
| The {{MediaSession}} interface is an extension to {{Navigator}}. As there is an |
There was a problem hiding this comment.
The {{MediaSession}} interface is an extension to {{Navigator}}.
That should be evident from the IDL, so this is redundant.
This was referenced Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look. Though it is still rough now.