Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define DisplayMediaStreamConstraints dictionary with video = true #92

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

jan-ivar
Copy link
Member

...and reject with TypeError on {video: false} and {video: false, audio}

Fix for #65 and #85.

Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nits

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
the user. If a <a>Constraints</a> structure is provided, it
further specifies desired processing options to be applied to
the audio Track. If <code>false</code>, the <a>MediaStream</a>
MUST NOT contain an audio Track.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Track

@jan-ivar
Copy link
Member Author

Test in web-platform-tests/wpt#14685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants